Finish Asteroids engine-owned chrome and add font manifest asset - PR 11.90

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,21 +1,14 @@
-# Codex command
+# Codex Commands — PR 11.90
 
-Run from repo root:
+Model: GPT-5.4
+Reasoning: high
 
-```powershell
-codex exec --model gpt-5.4-codex --reasoning high --sandbox workspace-write --ask-for-approval never @docs/pr/BUILD_PR_LEVEL_11_89_ASTEROIDS_ENGINE_RENDER_OWNERSHIP_STABILIZATION.md
-```
-
-## Required output from Codex
-Codex must create a ZIP artifact at:
+Run Codex with this task:
 
 ```text
-C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\tmp\PR_11_89_ASTEROIDS_ENGINE_RENDER_OWNERSHIP_STABILIZATION.zip
-```
+Apply PR 11.90 from docs/pr/PR_11_90_ASTEROIDS_ENGINE_OWNERSHIP_AND_FONT_MANIFEST.md.
 
-The ZIP must include changed repo files and:
-- docs/pr/PLAN_PR_LEVEL_11_89_ASTEROIDS_ENGINE_RENDER_OWNERSHIP_STABILIZATION.md
-- docs/pr/BUILD_PR_LEVEL_11_89_ASTEROIDS_ENGINE_RENDER_OWNERSHIP_STABILIZATION.md
-- docs/dev/reports/pr_11_89_asteroids_engine_render_ownership_report.md
-- docs/dev/codex_commands.md
-- docs/dev/commit_comment.txt
+Use the uploaded Asteroids.zip inspection findings as evidence. Finish Asteroids engine ownership correctness: remove remaining game-level background/clear/bezel ownership, keep gameplay-only rendering in Asteroids, make game.manifest.json the only source for bezel/background/font assets, add font.asteroids.vector-battle under asset-browser.assets, set image.asteroids.bezel to bezel1.png with stretchOverride.uniformEdgeStretchPx=10, set image.asteroids.background to deluxe.png, and verify no guessed chrome asset paths remain.
+
+Return a repo-structured ZIP at <project folder>/tmp/PR_11_90_ASTEROIDS_ENGINE_OWNERSHIP_AND_FONT_MANIFEST.zip with changed files and a short validation report.
+```

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Finish Asteroids engine-owned background/bezel layering and manifest-only chrome loading - PR 11.89
+Finish Asteroids engine-owned chrome and add font manifest asset - PR 11.90

docs/dev/reports/asteroids_zip_inspection.md

@@ -0,0 +1,20 @@
+# Asteroids.zip Inspection Report
+
+Inspected uploaded `Asteroids.zip`.
+
+## Remaining overrides found
+
+- `game/AsteroidsGameScene.js` calls `renderer.drawRect(0, 0, this.world.bounds.width, this.world.bounds.height, ...)` at the start of `render()`.
+- `game/AsteroidsAttractAdapter.js` calls `renderer.drawRect(0, 0, 960, 720, ...)` in `render()`.
+- `game/FullscreenBezelOverlay.js` contains Asteroids-specific fullscreen bezel path resolution and rendering behavior. This duplicates the engine-owned chrome layer unless fully delegated to the engine.
+
+## Manifest findings
+
+- `assets/fonts/vector_battle.ttf` exists.
+- No `font.*` entry exists in `game.manifest.json` under `asset-browser.assets`.
+- `image.asteroids.background` points to `/games/Asteroids/assets/images/deluxe.png`.
+- `image.asteroids.bezel` currently points to `/games/Asteroids/assets/images/bezel.png`; the requested SSoT path is `/games/Asteroids/assets/images/bezel1.png`.
+
+## Required resolution
+
+Asteroids should keep gameplay visuals only. Engine should own background, bezel, clear behavior, asset loading, and chrome layering.

docs/dev/reports/pr_11_90_validation.md

@@ -0,0 +1,47 @@
+# PR 11.90 Validation
+
+## Scope
+Applied `docs/pr/PR_11_90_ASTEROIDS_ENGINE_OWNERSHIP_AND_FONT_MANIFEST.md` using the uploaded Asteroids.zip findings as the baseline evidence.
+
+## Files Changed
+- `games/Asteroids/game.manifest.json`
+- `games/Asteroids/game/AsteroidsGameScene.js`
+- `games/Asteroids/game/AsteroidsAttractAdapter.js`
+- `games/Asteroids/game/FullscreenBezelOverlay.js`
+- `games/Asteroids/assets/images/bezel1.png`
+- `docs/dev/reports/pr_11_90_validation.md`
+
+## What Was Fixed
+- Manifest SSoT updates:
+  - `image.asteroids.bezel.path` set to `/games/Asteroids/assets/images/bezel1.png`
+  - `image.asteroids.background.path` set to `/games/Asteroids/assets/images/deluxe.png`
+  - `image.asteroids.bezel.stretchOverride.uniformEdgeStretchPx` remains `10`
+  - Added `font.asteroids.vector-battle` under `asset-browser.assets.media`:
+    - `/games/Asteroids/assets/fonts/vector_battle.ttf`
+- Removed remaining game-level frame background ownership:
+  - Removed full-canvas background draw from `AsteroidsGameScene.render()`.
+- Removed game-level full-frame attract dim ownership:
+  - Removed full-canvas attract overlay fill from `AsteroidsAttractAdapter.render()`.
+- Deprecated game-local bezel renderer path:
+  - `FullscreenBezelOverlay` now no-ops with `reason: deprecated-engine-owned` to avoid duplicate chrome ownership.
+
+## Targeted Validation
+- Syntax checks:
+  - `node --check games/Asteroids/game/AsteroidsGameScene.js` PASS
+  - `node --check games/Asteroids/game/AsteroidsAttractAdapter.js` PASS
+  - `node --check games/Asteroids/game/FullscreenBezelOverlay.js` PASS
+- Manifest verification:
+  - `rg -n "image.asteroids.bezel|image.asteroids.background|font.asteroids.vector-battle|bezel1.png|deluxe.png|stretchOverride" games/Asteroids/game.manifest.json`
+  - Confirmed expected entries/values.
+- Forbidden guessed path search:
+  - `rg -n "/games/Asteroids/assets/images/bezel\.png|/games/Asteroids/assets/images/background\.png|/games/SolarSystem/assets/images/bezel\.png|/games/SolarSystem/assets/images/background\.png" src games tools -g "*.js" -g "*.mjs" -g "*.json" -g "*.html"`
+  - No matches in active source/runtime scope.
+- Engine utils literal reference search:
+  - `rg -n "src/engine/utils/|/src/engine/utils/" src games -g "*.js" -g "*.mjs" -g "*.json" -g "*.html"`
+  - No matches.
+- Runtime launch check:
+  - `npm run test:launch-smoke:games` PASS (12/12, including Asteroids and SolarSystem).
+
+## Notes
+- Full sample suite was not run (targeted validation only, per PR scope).
+- Manual browser state-by-state visual verification was not executed in this CLI-only run; automated launch smoke and code-path checks were used as evidence.

docs/pr/PR_11_90_ASTEROIDS_ENGINE_OWNERSHIP_AND_FONT_MANIFEST.md

@@ -0,0 +1,97 @@
+# PR 11.90 — Asteroids Engine Ownership and Font Manifest Repair
+
+## Purpose
+Finish Asteroids alignment with the engine-owned render/chrome contract and add the Asteroids font to the asset-browser manifest assets.
+
+## Findings from uploaded Asteroids.zip
+
+The uploaded Asteroids game still contains game-level render/chrome overrides:
+
+1. `games/Asteroids/game/AsteroidsGameScene.js` still draws a full-screen rect at the start of `render()`.
+   - This means Asteroids still controls the frame background/clear layer.
+   - When a manifest background exists, the fill is translucent, but the game is still overriding engine-owned background layering.
+
+2. `games/Asteroids/game/AsteroidsAttractAdapter.js` still draws a full-screen attract overlay.
+   - It is translucent when a manifest background exists, but it is still a full-frame game overlay that can visually suppress the engine background.
+   - Keep only intentional text/sprite/menu visuals; do not use an opaque/near-opaque frame fill as a background substitute.
+
+3. `games/Asteroids/game/FullscreenBezelOverlay.js` still contains Asteroids-specific bezel resolution.
+   - Bezel/background should be engine-owned and manifest-driven.
+   - Remove/deprecate game-local fullscreen bezel loading/rendering when the engine chrome layer provides this behavior.
+
+4. `games/Asteroids/game.manifest.json` has the bezel path set to `/games/Asteroids/assets/images/bezel.png`.
+   - The desired Asteroids bezel is `/games/Asteroids/assets/images/bezel1.png`.
+   - Keep `stretchOverride.uniformEdgeStretchPx = 10` only on `image.asteroids.bezel`.
+
+5. `games/Asteroids/assets/fonts/vector_battle.ttf` exists, but no font asset entry is present in `asset-browser.assets`.
+
+## Required changes
+
+### Manifest assets
+Update `games/Asteroids/game.manifest.json`:
+
+- Ensure `asset-browser.assets.image.asteroids.bezel.path` is `/games/Asteroids/assets/images/bezel1.png`.
+- Ensure `asset-browser.assets.image.asteroids.background.path` is `/games/Asteroids/assets/images/deluxe.png`.
+- Ensure `asset-browser.assets.image.asteroids.bezel.stretchOverride.uniformEdgeStretchPx` is `10`.
+- Add a font asset entry:
+
+```json
+"font.asteroids.vector-battle": {
+  "path": "/games/Asteroids/assets/fonts/vector_battle.ttf",
+  "kind": "font",
+  "source": "workspace-manager"
+}
+```
+
+Do not place font data outside `asset-browser.assets`.
+
+### Engine ownership
+Asteroids must not own engine chrome/background/clear responsibilities.
+
+Codex must remove or neutralize these remaining overrides:
+
+- `AsteroidsGameScene.render()` full-screen background/clear fill.
+- `AsteroidsAttractAdapter.render()` full-screen dark frame fill when a manifest background exists.
+- Any Asteroids-local bezel/background loader/renderer that duplicates engine chrome responsibilities, especially `FullscreenBezelOverlay.js`, unless it is still directly required and only delegates to the engine manifest chrome layer.
+
+Gameplay rendering remains in Asteroids:
+
+- ships
+- asteroids
+- bullets
+- saucers
+- score/lives/menu/high-score text
+- intentional game-specific vector visuals
+
+### No fallback asset guessing
+Do not introduce fallback paths such as:
+
+- `/games/Asteroids/assets/images/bezel.png`
+- `/games/Asteroids/assets/images/background.png`
+- `/games/SolarSystem/assets/images/bezel.png`
+- `/games/SolarSystem/assets/images/background.png`
+
+Game chrome assets must resolve only through manifest asset ids.
+
+## Acceptance
+
+- `game.manifest.json` includes font, bezel, and background assets under `asset-browser.assets`.
+- `image.asteroids.bezel` uses `bezel1.png`.
+- `image.asteroids.background` uses `deluxe.png`.
+- `image.asteroids.bezel.stretchOverride.uniformEdgeStretchPx` is `10`.
+- There is no `asset-browser.assets.bezel` duplicate contract.
+- Asteroids no longer draws an engine-owned background/clear layer.
+- Asteroids no longer uses game-local bezel/background loading/rendering that bypasses the engine manifest layer.
+- No 404s for bezel/background/font assets.
+- Background is visible in menu, attract, pause, and gameplay.
+- Bezel is visible and stretched using the manifest SSoT value.
+
+## Testing
+
+Run targeted tests only. Do not run the full samples smoke test.
+
+1. Open `games/Asteroids/index.html`.
+2. Confirm menu/attract/gameplay/pause all keep the manifest background visible.
+3. Confirm the bezel renders from `image.asteroids.bezel`.
+4. Confirm no console 404s for chrome assets or font.
+5. Search repo for forbidden paths and stale references.

games/Asteroids/assets/images/bezel1.png

@@ -181,8 +181,13 @@
             "kind": "audio",
             "source": "workspace-manager"
           },
+          "font.asteroids.vector-battle": {
+            "path": "/games/Asteroids/assets/fonts/vector_battle.ttf",
+            "kind": "font",
+            "source": "workspace-manager"
+          },
           "image.asteroids.bezel": {
-            "path": "/games/Asteroids/assets/images/bezel.png",
+            "path": "/games/Asteroids/assets/images/bezel1.png",
             "kind": "image",
             "source": "workspace-manager",
             "stretchOverride": {

games/Asteroids/game.manifest.json

@@ -238,20 +238,12 @@ export default class AsteroidsAttractAdapter {
     });
   }
 
-  render(renderer, options = {}) {
+  render(renderer) {
     if (!this.active) {
       return;
     }
 
     const alpha = this.getPhaseAlpha();
-    const manifestBackgroundPresent = options?.manifestBackgroundPresent === true;
-    renderer.drawRect(
-      0,
-      0,
-      960,
-      720,
-      manifestBackgroundPresent ? 'rgba(2, 6, 23, 0.36)' : 'rgba(2, 6, 23, 0.86)'
-    );
 
     if (this.phase === 'title') {
       this.renderTitle(renderer, alpha);

games/Asteroids/game/AsteroidsAttractAdapter.js

@@ -95,17 +95,6 @@ function drawLives(renderer, centerX, y, lives) {
   });
 }
 
-function hasManifestBackgroundLayer(engine) {
-  const state = engine?.backgroundImageLayer?.getState?.();
-  if (!state || typeof state !== 'object') {
-    return false;
-  }
-  return typeof state.path === 'string'
-    && state.path.trim().length > 0
-    && state.status !== 'missing'
-    && state.status !== 'unavailable';
-}
-
 export default class AsteroidsGameScene extends Scene {
   constructor(options = {}) {
     super();
@@ -702,14 +691,6 @@ export default class AsteroidsGameScene extends Scene {
   render(renderer, engine) {
     const leaderboardTopScore = this.highScoreService.getTopScore(this.highScoreRows);
     const liveHudHighScore = Math.max(this.session.highScore, leaderboardTopScore);
-    const manifestBackgroundPresent = hasManifestBackgroundLayer(engine);
-    renderer.drawRect(
-      0,
-      0,
-      this.world.bounds.width,
-      this.world.bounds.height,
-      manifestBackgroundPresent ? 'rgba(2, 6, 23, 0.22)' : '#020617'
-    );
     this.world.starfield.forEach((star) => {
       renderer.drawRect(star.x, star.y, star.size, star.size, '#94a3b8');
     });
@@ -780,9 +761,7 @@ export default class AsteroidsGameScene extends Scene {
 
     if (this.session.mode === 'menu') {
       if (this.attractController.active) {
-        this.attractAdapter.render(renderer, {
-          manifestBackgroundPresent
-        });
+        this.attractAdapter.render(renderer);
       } else {
         renderer.drawText('ASTEROIDS', 480, 220, {
           color: '#ffffff',

games/Asteroids/game/AsteroidsGameScene.js

@@ -46,21 +46,7 @@ export default class FullscreenBezelOverlay {
   }
 
   ensureImageLoaded() {
-    if (!this.enabled || this.image || this.imageLoadStarted || typeof Image !== "function") {
-      return;
-    }
-
-    this.imageLoadStarted = true;
-    const image = new Image();
-    image.onload = () => {
-      this.image = image;
-      this.imageStatus = "loaded";
-    };
-    image.onerror = () => {
-      this.imageStatus = "error";
-    };
-    image.src = this.assetPath;
-    this.imageStatus = "loading";
+    this.imageStatus = "deprecated-engine-owned";
   }
 
   evaluateRenderGate(options = {}) {
@@ -86,49 +72,11 @@ export default class FullscreenBezelOverlay {
   }
 
   render(renderer, options = {}) {
-    const gate = this.evaluateRenderGate(options);
-    if (!gate.allowed) {
-      return {
-        drawn: false,
-        ...gate,
-        assetPath: this.assetPath
-      };
-    }
-
-    this.ensureImageLoaded();
-    const image = options.image || this.image;
-    if (!image || typeof renderer?.drawImageFrame !== "function") {
-      return {
-        drawn: false,
-        reason: "image-unavailable",
-        drawMode: this.drawMode,
-        assetPath: this.assetPath
-      };
-    }
-
-    const canvasSize = renderer?.getCanvasSize?.() || options.canvasSize || { width: 0, height: 0 };
-    const width = Number(canvasSize.width) > 0 ? Number(canvasSize.width) : 0;
-    const height = Number(canvasSize.height) > 0 ? Number(canvasSize.height) : 0;
-    if (width <= 0 || height <= 0) {
-      return {
-        drawn: false,
-        reason: "invalid-canvas-size",
-        drawMode: this.drawMode,
-        assetPath: this.assetPath
-      };
-    }
-
-    const sourceWidth = Number(image.width) > 0 ? Number(image.width) : width;
-    const sourceHeight = Number(image.height) > 0 ? Number(image.height) : height;
-    renderer.drawImageFrame(image, 0, 0, sourceWidth, sourceHeight, 0, 0, width, height);
     return {
-      drawn: true,
-      drawMode: this.drawMode,
-      fullscreenOnly: true,
-      coordinateSpace: "screen-space",
+      drawn: false,
+      reason: "deprecated-engine-owned",
       assetPath: this.assetPath,
-      width,
-      height
+      drawMode: this.drawMode
     };
   }
 }