|
| 1 | +# PR_26140_072 Engine Debug Index Barrel Removal |
| 2 | + |
| 3 | +## Summary |
| 4 | +- Removed active imports from the targeted debug index barrels: |
| 5 | + - `src/engine/debug/index.js` |
| 6 | + - `src/engine/debug/standard/threeD/index.js` |
| 7 | + - `src/engine/debug/network/index.js` |
| 8 | + - `src/engine/debug/inspectors/index.js` |
| 9 | +- Replaced debug barrel imports with direct canonical imports to the owning debug files. |
| 10 | +- Deleted the four targeted debug index barrel files after active imports were removed. |
| 11 | +- Kept changes import-only. No schema files, sample JSON, sample/game entry `index.js` files, Git commits, pushes, or GitHub PRs were created. |
| 12 | + |
| 13 | +## Direct Import Mapping |
| 14 | +- Debug panels: |
| 15 | + - `drawSceneFrame`, `drawFrame`, `drawPanel` -> `src/engine/debug/DebugPanel.js` |
| 16 | + - stacked debug panel helpers -> `src/engine/debug/DebugOverlayLayout.js` |
| 17 | + - combat/debug overlay helpers -> their owning files under `src/engine/debug/` |
| 18 | +- Standard 3D debug: |
| 19 | + - provider registry and provider constants/helpers -> `src/engine/debug/standard/threeD/providers/*` |
| 20 | + - panel registry and panel constants/helpers -> `src/engine/debug/standard/threeD/panels/*` |
| 21 | + - presets/bootstrap helpers -> `src/engine/debug/standard/threeD/presets/*` and `bootstrap/*` |
| 22 | +- Network debug: |
| 23 | + - providers, panels, command packs, dashboard helpers, and diagnostics now import from their owning files under `src/engine/debug/network/` |
| 24 | +- Advanced inspectors: |
| 25 | + - registry, host, commands, bootstrap, presets, and view models now import from owning files under `src/engine/debug/inspectors/` |
| 26 | + |
| 27 | +## Validation |
| 28 | +- PASS: debug barrel scan reports `NO_DEBUG_BARREL_IMPORTS`. |
| 29 | +- PASS: target deletion scan confirms all four targeted debug `index.js` files no longer exist. |
| 30 | +- PASS: no JSON files changed. |
| 31 | +- PASS: `node --check` passed for 226 changed existing JS/MJS files. |
| 32 | +- PASS: local import target validation passed for 226 changed existing JS/MJS files. |
| 33 | +- PASS: `npm run test:workspace-v2` passed 59/59 tests. |
| 34 | +- PASS: focused debug Node tests passed: |
| 35 | + - `tests/final/DebugObservabilityMaturity.test.mjs` |
| 36 | + - `tests/final/NetworkDebugAndServerDashboardCloseout.test.mjs` |
| 37 | + - `tests/tools/CameraDebugPanel.test.mjs` |
| 38 | + - `tests/tools/CollisionOverlaysDebugPanel.test.mjs` |
| 39 | + - `tests/tools/RenderPipelineStagesDebugPanel.test.mjs` |
| 40 | + - `tests/tools/SceneGraphInspectorDebugPanel.test.mjs` |
| 41 | + - `tests/tools/TransformInspectorDebugPanel.test.mjs` |
| 42 | +- FAIL: `tests/runtime/Phase17DebugOverlayBottomRightPosition.test.mjs` |
| 43 | + - Failure: Node could not resolve browser-root import `/src/engine/scene/Scene.js` from `samples/phase-17/1701/RaycastDemoScene.js`. |
| 44 | + - Error path: `C:\src\engine\scene\Scene.js`. |
| 45 | + - This surfaced during extra focused debug validation and appears related to existing Node execution of browser-root sample imports, not to debug barrel ownership. |
| 46 | +- STOPPED: per unattended workflow instruction, PR_26140_073 and PR_26140_074 were not started after this validation failure. |
| 47 | +- SKIPPED: full samples smoke test, per instruction. |
0 commit comments