Skip to content

Commit 9eaf0b9

Browse files
author
DavidQ
committed
Remove two verified dead tool-specific JSON payloads from audit cleanup - PR 11.50
1 parent 48020a9 commit 9eaf0b9

12 files changed

Lines changed: 117 additions & 7524 deletions

docs/dev/codex_commands.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
# Codex Commands - PR 11.49
1+
# Codex Commands PR 11.50
22

33
Model: GPT-5.4
44
Reasoning: high
55

66
```powershell
7-
codex --model gpt-5.4 --reasoning high "Run BUILD_PR_LEVEL_11_49_CONTROLLED_JSON_CLEANUP exactly as written. Use docs/pr/PR_11_49_CONTROLLED_JSON_CLEANUP/BUILD_PR.md as the source of truth. Run the audit script, select exactly two safe tool-specific NO JSON items, validate manually, apply only confirmed cleanup, run targeted checks, rerun audit, write reports under docs/dev/reports, update only status markers in the roadmap if execution-backed, and create the final repo-structured ZIP at C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\tmp\PR_11_49_CONTROLLED_JSON_CLEANUP.zip. Do not run the full samples suite unless shared loader/framework files are changed."
7+
cd C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming
8+
codex --model gpt-5.4 --reasoning high "Run PR 11.50 from docs/pr/PR_11_50_CONTROLLED_JSON_CLEANUP.md. Execute the audit script, choose exactly two safe tool-specific NO JSON files, verify manually, remove only confirmed dead JSON files, capture before/after audit reports under docs/dev/reports, run targeted validation only, and create the final repo ZIP at tmp/PR_11_50_CONTROLLED_JSON_CLEANUP.zip. Do not touch palette.json, tile-map-editor-document.json, sample 1902, roadmap text, shared loaders, or framework code."
89
```
9-

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Resolve two safe sample-local NO audit JSON artifacts (sample 1208 data intermediates) with targeted validation - PR 11.49
1+
Remove two verified NO sample JSON payloads in controlled cleanup (1208) with targeted validation and audit delta - PR 11.50
19.7 KB
Binary file not shown.
20.3 KB
Binary file not shown.
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
# PR 11.50 Controlled JSON Cleanup Report
2+
3+
## Audit Before Summary
4+
- Source: `docs/dev/reports/PR_11_50_audit_before.txt`
5+
- JSON files scanned: 96
6+
- Referenced: 39
7+
- Missing reference (`NO`): 57
8+
9+
## Selected Files (Exactly Two)
10+
1. `samples/phase-12/1208/assets/data/tileset/demo1208-terrain-tileset.sprite-editor.json`
11+
2. `samples/phase-12/1208/sample.1208.3d-json-payload-normalizer.json`
12+
13+
Both were selected from the audit `NO` list and are tool-specific sample payload artifacts.
14+
15+
## Manual Verification
16+
### 1) `demo1208-terrain-tileset.sprite-editor.json`
17+
- Filename search: no runtime/tool usage references.
18+
- Basename search: no runtime/tool usage references.
19+
- Metadata indirect reference check: none.
20+
- Result: confirmed dead.
21+
22+
### 2) `sample.1208.3d-json-payload-normalizer.json`
23+
- Filename search: only metadata/audit report mentions.
24+
- Basename search: only metadata/audit report mentions.
25+
- Indirect reference check:
26+
- Prior indirect usage existed through sample metadata (`roundtripToolPresets`/`toolHints`) for sample `1208`.
27+
- Removed that stale sample-specific metadata wiring for `3d-json-payload-normalizer` and rechecked references.
28+
- Post-update: no runtime/tool/metadata references remain.
29+
- Result: confirmed dead after stale indirect mapping cleanup.
30+
31+
## Action Taken
32+
- Deleted:
33+
- `samples/phase-12/1208/assets/data/tileset/demo1208-terrain-tileset.sprite-editor.json`
34+
- `samples/phase-12/1208/sample.1208.3d-json-payload-normalizer.json`
35+
- Updated:
36+
- `samples/metadata/samples.index.metadata.json`
37+
- Removed `3d-json-payload-normalizer` from sample `1208` `toolHints`.
38+
- Removed sample `1208` `roundtripToolPresets` entry for `3d-json-payload-normalizer`.
39+
40+
## Exclusion Compliance
41+
- Did not touch any `palette.json` files.
42+
- Did not touch any `tile-map-editor-document.json` files.
43+
- Did not touch sample `1902` files.
44+
- Did not modify shared loaders/framework code.
45+
- Did not modify roadmap text.
46+
47+
## Targeted Validation
48+
- `node --check` changed JS files:
49+
- N/A (no JavaScript files changed)
50+
- Targeted sample validation:
51+
- `node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=1208-1208`
52+
- Result: PASS (`PASS=1 FAIL=0 TOTAL=1`)
53+
54+
## Full Suite Decision
55+
- Full samples suite: skipped.
56+
- Reason: this PR only performs sample-local JSON cleanup and sample metadata unlinking, with no shared loader/framework changes.
57+
58+
## Audit After Summary
59+
- Source: `docs/dev/reports/PR_11_50_audit_after.txt`
60+
- JSON files scanned: 94
61+
- Referenced: 39
62+
- Missing reference (`NO`): 55
63+
- Net change: exactly 2 JSON files removed (scan count reduced by two).
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR 11.50 Validation Plan
2+
3+
## Required Checks
4+
- Run `scripts/PS/audit-sample-json-js-references.ps1` before and after cleanup.
5+
- Confirm selected files are reported as NO before removal.
6+
- Confirm selected files have no JS references.
7+
- Confirm selected files are not indirectly used.
8+
- Confirm audit total count decreases by exactly two.
9+
10+
## Full Samples Test
11+
Skipped by default.
12+
13+
Reason: this PR only removes two confirmed dead tool-specific JSON payloads and does not modify shared loader/framework code.
14+
15+
## Targeted Validation
16+
- Audit before/after.
17+
- Git diff review.
18+
- Any affected tool/sample page smoke check if the removed payload belongs to a visible tool route.

docs/dev/reports/launch_smoke_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Launch Smoke Report
22

3-
Generated: 2026-04-29T20:34:40.651Z
3+
Generated: 2026-04-29T20:44:47.603Z
44

55
Filters: games=false, samples=true, tools=false, sampleRange=1208-1208
66

docs/dev/reports/sample_json_js_reference_audit.csv

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@
5656
"samples\phase-12\1205","samples\phase-12\1205\sample.1205.palette.json","False","","",""
5757
"samples\phase-12\1205","samples\phase-12\1205\sample.1205.parallax-editor.json","False","","",""
5858
"samples\phase-12\1205","samples\phase-12\1205\sample.1205.vector-map-editor.json","False","","",""
59-
"samples\phase-12\1208","samples\phase-12\1208\assets\data\tileset\demo1208-terrain-tileset.sprite-editor.json","False","","",""
6059
"samples\phase-12\1208","samples\phase-12\1208\sample.1208.3d-asset-viewer.json","False","","",""
61-
"samples\phase-12\1208","samples\phase-12\1208\sample.1208.3d-json-payload-normalizer.json","False","","",""
6260
"samples\phase-12\1208","samples\phase-12\1208\sample.1208.palette.json","False","","",""
6361
"samples\phase-12\1208","samples\phase-12\1208\sample.1208.parallax-editor.json","True","index.html","sample\.1208\.parallax-editor\.json","Multiple JS references found"
6462
"samples\phase-12\1208","samples\phase-12\1208\sample.1208.svg-asset-studio.json","True","index.html","sample\.1208\.svg-asset-studio\.json",""
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# PR 11.50 — Controlled JSON Cleanup
2+
3+
## Purpose
4+
Continue CONTROLLED CLEANUP MODE by removing exactly two verified tool-specific JSON files reported as NO by the audit script.
5+
6+
## Scope
7+
- Run `scripts/PS/audit-sample-json-js-references.ps1`.
8+
- Select exactly two safe NO JSON items from tool-specific sample/tool payloads.
9+
- Do not touch `palette.json`.
10+
- Do not touch `tile-map-editor-document.json`.
11+
- Do not touch sample 1902.
12+
- Do not modify roadmap text except status-only if execution-backed.
13+
- Do not refactor loader/framework/shared code.
14+
15+
## Codex Execution Requirements
16+
1. Run the audit script.
17+
2. Capture audit output in `docs/dev/reports/PR_11_50_audit_before.txt`.
18+
3. Pick exactly two clean NO items that are tool-specific and not shared.
19+
4. Manually verify there are no JS references and no indirect references.
20+
5. Remove only those two confirmed dead JSON files.
21+
6. Run the audit script again.
22+
7. Capture output in `docs/dev/reports/PR_11_50_audit_after.txt`.
23+
8. Run targeted validation only.
24+
9. Document full-suite skip reason.
25+
26+
## Acceptance
27+
- Exactly two verified dead JSON files removed.
28+
- Audit after output shows total count reduced by two.
29+
- No shared payload files touched.
30+
- No roadmap rewrite/deletion.
31+
- Targeted tests documented.

samples/metadata/samples.index.metadata.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6775,7 +6775,6 @@
67756775
],
67766776
"toolHints": [
67776777
"3d-asset-viewer",
6778-
"3d-json-payload-normalizer",
67796778
"parallax-editor",
67806779
"tile-map-editor",
67816780
"svg-asset-studio",
@@ -6786,10 +6785,6 @@
67866785
"toolId": "3d-asset-viewer",
67876786
"presetPath": "/samples/phase-12/1208/sample.1208.3d-asset-viewer.json"
67886787
},
6789-
{
6790-
"toolId": "3d-json-payload-normalizer",
6791-
"presetPath": "/samples/phase-12/1208/sample.1208.3d-json-payload-normalizer.json"
6792-
},
67936788
{
67946789
"toolId": "parallax-editor",
67956790
"presetPath": "/samples/phase-12/1208/sample.1208.parallax-editor.json"

0 commit comments

Comments
 (0)