Skip to content

Commit a9cd5c0

Browse files
author
DavidQ
committed
Move Palette Manager V2 validation clear button into viewer header and preserve future errors - PR_26124_065-palette-manager-validation-clear-in-viewer
1 parent 2254d89 commit a9cd5c0

10 files changed

Lines changed: 345 additions & 148 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,27 @@
1-
# Codex Commands - PR_26124_064-palette-manager-source-pin-scroll-preserve
1+
# Codex Commands - PR_26124_065-palette-manager-validation-clear-in-viewer
22

33
## Workflow
44
- Read `docs/dev/PROJECT_INSTRUCTIONS.md`.
55
- Used `.codex/skills/repo-build/SKILL.md`.
66
- Checked git status before implementation.
7-
- Created `docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/PLAN_PR.md`.
8-
- Created `docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/BUILD_PR.md`.
7+
- Created `docs/pr/PR_26124_065-palette-manager-validation-clear-in-viewer/PLAN_PR.md`.
8+
- Created `docs/pr/PR_26124_065-palette-manager-validation-clear-in-viewer/BUILD_PR.md`.
99
- Read the active BUILD doc before changing runtime files.
10-
- Updated only `tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js`.
11-
- Created `docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/APPLY_PR.md`.
10+
- Updated `tools/palette-manager-v2/index.html`.
11+
- Updated `tools/palette-manager-v2/paletteManagerV2.css`.
12+
- Created `docs/pr/PR_26124_065-palette-manager-validation-clear-in-viewer/APPLY_PR.md`.
1213

1314
## Validation Commands
14-
- `node --check tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js`
15-
- Targeted served-browser Palette Manager V2 individual source pin/unpin scroll preservation validation using Playwright from Node.
15+
- Targeted served-browser Palette Manager V2 Validation/Error Viewer Clear placement and behavior validation using Playwright from Node.
1616
- `git diff --check`
1717
- `npm run test:workspace-v2`
1818
- `git diff --cached --check`
1919
- `npm run codex:review-artifacts`
20-
- Python `zipfile` packaging for `tmp/PR_26124_064-palette-manager-source-pin-scroll-preserve_delta.zip`
20+
- Python `zipfile` packaging for `tmp/PR_26124_065-palette-manager-validation-clear-in-viewer_delta.zip`
2121

2222
## Validation Outcome
23-
- JavaScript syntax check: PASS.
24-
- Targeted served-browser Palette Manager V2 individual source pin/unpin scroll preservation validation: PASS.
25-
- `git diff --check`: PASS with Git LF-to-CRLF warning for generated review artifact.
23+
- Targeted served-browser Palette Manager V2 Validation/Error Viewer Clear validation: PASS.
24+
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed Palette Manager files.
2625
- `git diff --cached --check`: PASS.
2726
- `npm run test:workspace-v2`: FAILED because the script is missing from `package.json`.
2827
- Review artifacts: generated.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Preserve Palette Manager source scroll after pin render - PR_26124_064-palette-manager-source-pin-scroll-preserve
1+
Move Palette Manager validation Clear into viewer header - PR_26124_065-palette-manager-validation-clear-in-viewer
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# PR_26124_065-palette-manager-validation-clear-in-viewer Report
2+
3+
## Summary
4+
Implemented a Palette Manager V2-only UI placement update for Validation/Error Viewer Clear.
5+
6+
## Changes
7+
- The Validation/Error Viewer Clear button now appears in the Validation/Error Viewer header/control area.
8+
- The old in-content Clear button wrapper was removed.
9+
- The existing Clear behavior is preserved:
10+
- displayed status/errors are cleared,
11+
- palette state is not changed,
12+
- the next validation/error event displays normally.
13+
14+
## Validation
15+
- Targeted served-browser Palette Manager V2 Validation/Error Viewer Clear placement and behavior validation: PASS.
16+
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed Palette Manager files.
17+
- `npm run test:workspace-v2`: FAIL, `package.json` does not define `test:workspace-v2`.
18+
- Full samples smoke test: skipped because this PR is limited to Palette Manager V2 Validation/Error Viewer UI placement and sample JSON remains out of scope.
19+
20+
## Manual Test Notes
21+
1. Open Palette Manager V2.
22+
2. Confirm `Clear` is in the Validation/Error Viewer header/control area.
23+
3. Trigger a validation error.
24+
4. Click `Clear` and confirm displayed status/errors are removed.
25+
5. Trigger another validation error and confirm it displays normally.
26+
6. Confirm palette state, swatch state, tags, sorting, pinning, import/export data, pin button size, and source/sample pin scroll behavior are unchanged.
Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
# git status --short
22
M docs/dev/codex_commands.md
33
M docs/dev/commit_comment.txt
4-
A docs/dev/reports/PR_26124_064_report.md
5-
M docs/dev/reports/codex_changed_files.txt
6-
M docs/dev/reports/codex_review.diff
7-
A docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/APPLY_PR.md
8-
A docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/BUILD_PR.md
9-
A docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/PLAN_PR.md
10-
M tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js
4+
A docs/dev/reports/PR_26124_065_report.md
5+
A docs/pr/PR_26124_065-palette-manager-validation-clear-in-viewer/APPLY_PR.md
6+
A docs/pr/PR_26124_065-palette-manager-validation-clear-in-viewer/BUILD_PR.md
7+
A docs/pr/PR_26124_065-palette-manager-validation-clear-in-viewer/PLAN_PR.md
8+
M tools/palette-manager-v2/index.html
9+
M tools/palette-manager-v2/paletteManagerV2.css
1110

1211
# git diff --stat
13-
docs/dev/reports/codex_changed_files.txt | 18 +-
14-
docs/dev/reports/codex_review.diff | 1738 +++---------------------------
15-
2 files changed, 129 insertions(+), 1627 deletions(-)
12+
(no output)

0 commit comments

Comments
 (0)