Skip to content

Commit b45a1e3

Browse files
author
DavidQ
committed
Clean up Object Vector Studio V2 preview palette sync grid scale and accordion layout - PR_26133_002-object-vector-studio-preview-palette-cleanup
1 parent f60bff7 commit b45a1e3

7 files changed

Lines changed: 283 additions & 67 deletions

File tree

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
# PR_26133_001 Playwright V8 Coverage Report
1+
# PR_26133_002 Playwright V8 Coverage Report
22

3-
Coverage source: `docs/dev/reports/playwright_v8_coverage.txt`, refreshed by the Workspace V2 Playwright run.
3+
Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed by `npm run test:workspace-v2`.
44

55
## Summary
66

77
- Coverage is advisory only; no thresholds are enforced.
88
- Workspace Manager V2 entry point: 91%.
99
- Object Vector Studio V2 changed runtime files covered:
10-
- `tools/object-vector-studio-v2/js/bootstrap.js`: 80%, executed lines 97/97, executed functions 4/5.
11-
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 90%, executed lines 3187/3187, executed functions 331/369.
12-
- The coverage report lists no low-coverage changed runtime JS files.
10+
- `tools/object-vector-studio-v2/js/bootstrap.js`: 80%, executed lines 99/99, executed functions 4/5.
11+
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 90%, executed lines 3270/3270, executed functions 342/378.
12+
- The generated report lists no low-coverage changed runtime JS files.
1313

1414
## Validation Context
1515

1616
- Main command: `npm run test:workspace-v2`.
1717
- Result: 45 passed.
18-
- Focused Object Vector Studio V2 layout/scroll contract test also passed.
18+
- Focused Object Vector Studio V2 layout/preview/palette scenario also passed.
Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,27 @@
1-
# PR_26133_001 Workspace V2 Results
1+
# PR_26133_002 Workspace V2 Results
22

33
## Command Results
44

55
- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`: passed.
66
- `node --check tools/object-vector-studio-v2/js/bootstrap.js`: passed.
77
- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`: passed.
8-
- `node -e` JSON parse for `games/Asteroids/game.manifest.json` and `tools/schemas/tools/object-vector-studio-v2.schema.json`: passed.
9-
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "shows Object Vector Studio V2 layout shell"`: 1 passed.
8+
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --grep "shows Object Vector Studio V2 layout shell"`: 1 passed.
109
- `npm run test:workspace-v2`: 45 passed.
1110
- `git diff --check`: passed.
1211

1312
## Targeted Object Vector Studio V2 Verification
1413

15-
- Standalone Object Vector Studio V2 Playwright manual pass reported `consoleErrors: []` and `pageErrors: []`.
16-
- Object selection preserved left-panel and Objects accordion scroll: before `{ leftPanel: 30, objects: 36 }`, after `{ leftPanel: 30, objects: 36 }`.
17-
- Shape selection preserved left-panel and Objects accordion scroll: before `{ leftPanel: 30, objects: 36 }`, after `{ leftPanel: 30, objects: 36 }`.
18-
- Shape/Tools content reached its accordion bottom.
19-
- Object Name and Tag rows were inline.
20-
- Shape row density measured `11.2px` font size and `22px` row height.
21-
- Left panel was scrollable during the verification pass.
14+
- Standalone Playwright manual pass reported `consoleErrors: []` and `pageErrors: []`.
15+
- Selected shape palette sync: rectangle restored cyan `#6fd3ff`; circle restored white `#ffffff`.
16+
- Centering dot button hid and restored the `data-center-origin="0,0"` marker.
17+
- Grid/object scale matched 1:1: rectangle `x=-80`, `y=-30`, `width=80`, `height=60`; grid included adjacent 10-unit lines and rectangle boundaries.
18+
- Grid snap moved a `13,7` edit to `10,10`.
19+
- Selection chrome measured 3x3 handles and `0.75px` dotted selection stroke.
20+
- Group action became enabled for multi-selection and assigned `group-1`.
21+
- Compact preview and palette accordions used `flex-grow: 0` and ended at content height; right rail remained scrollable.
2222

2323
## Contract Checks
2424

25-
- `objectType` UI controls remain absent from Object Vector Studio V2.
26-
- Object-level `type` drift remains rejected by the Object Vector Studio V2 schema path.
27-
- Exact Asteroids Object Vector `asteroids` tag search found no persisted tag values.
28-
- Existing Object Vector Studio V2 payload contracts remain schema-first with no `imageDataUrl` persistence.
25+
- Object Vector Studio V2 JSON remains palette-free.
26+
- No sample JSON files were modified.
27+
- No fallback behavior was added for palette sync or validation paths.

0 commit comments

Comments
 (0)