Plans for sovereign cloud support

[chughesvf]

any support planned for keyvaults in sovereign clouds like USGOV? the url regex is slightly different and would require some kind of input to know its destination.

[TraGicCode]

Hey @chughesvf,

I can try to take a look at this once things free up on my side. In the meantime, feel free to take a stab at a PR yourself—I'd be happy to review and accept it.

Also, if you have any resources or notes about what should change and/or how you'd expect this to be exposed as a feature, please share them here.

Thanks for using this module!

[TraGicCode]

I looked around and i think this is indeed a simple change. I can have a pr up in the next couple days that you can test and verify.

[TraGicCode]

Hey @chughesvf ,

can you please test #160 and let me know if this works correctly and correctly implements your feature request?

[chughesvf]

will be testing shortly thanks for the quick turnaround

[chughesvf]

tested on a gov vm, against a gov keyvault using the Deferred() function since we do not have a usgov based puppet server:

Used r10k to deploy the branch of changes

# key vault sovereign test
mod 'tragiccode-azure_key_vault',
  :git    => 'https://github.com/TraGicCode/tragiccode-azure_key_vault.git',
  :branch => 'GH-158-add-sovereign-cloud-support'

introduced code to puppet catalog to store secret in a file

    $secret = Deferred('azure_key_vault::secret', ['test_gov_kv', 'testpuppetazurekv', {
          metadata_api_version => '2018-02-01',
          vault_api_version    => '2016-10-01',
          cloud_type           => 'AzureUSGovernment',
    }])
    file { 'c:\\test.txt': ensure=> 'file', content=> $secret; }

changes to module are correctly deployed:

Notice: /File[C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet/functions/azure_key_vault]/ensure: created
Notice: /File[C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet/functions/azure_key_vault/lookup.rb]/ensure: defined content as '{sha256}32873dcbc632cada404970f10f3cf661d8350c8be0f724a49e0f075869917a15'
Notice: /File[C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet/functions/azure_key_vault/secret.rb]/ensure: defined content as '{sha256}b54cdd24cd6529c5d75f4da2585af9b0d6172eceb72f230b20fea2836d4fd662'
Notice: /File[C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet_x/tragiccode]/ensure: created
Notice: /File[C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet_x/tragiccode/azure.rb]/ensure: defined content as '{sha256}e21300eac54d4108a2fdba9f5e4be5a9930707b589828a3f093632fb41bdc980'

results:

PS C:\Windows\system32> cat C:\test.txt
it works
PS C:\Windows\system32> cat C:\test.txt
just to prove it really works

[TraGicCode]

Thanks a lot! I’ll go ahead and merge this and create a new release!