From 5b9f93774b1e9056ae80e13e98ff0d17cc1452d9 Mon Sep 17 00:00:00 2001 From: Nikolay Deshev Date: Tue, 14 Jul 2026 15:09:03 +0300 Subject: [PATCH 1/2] fix(ui5-rating-indicator): import default icons fixes: #13796 --- .../main/cypress/specs/RatingIndicator.cy.tsx | 22 +++++++++++++++++++ packages/main/src/RatingIndicator.ts | 2 ++ 2 files changed, 24 insertions(+) diff --git a/packages/main/cypress/specs/RatingIndicator.cy.tsx b/packages/main/cypress/specs/RatingIndicator.cy.tsx index 3e17309b82762..4ee1d933264fe 100644 --- a/packages/main/cypress/specs/RatingIndicator.cy.tsx +++ b/packages/main/cypress/specs/RatingIndicator.cy.tsx @@ -6,6 +6,28 @@ import "@ui5/webcomponents-icons/dist/thumb-up.js"; import "@ui5/webcomponents-icons/dist/thumb-down.js"; describe("RatingIndicator", () => { + describe("Default Icons Loading", () => { + it("should load and render the default 'favorite' and 'unfavorite' icons without explicit imports", () => { + cy.mount(); + + cy.get("[ui5-rating-indicator]") + .shadow() + .find(".ui5-rating-indicator-item-sel [ui5-icon]") + .first() + .shadow() + .find("svg") + .should("exist"); + + cy.get("[ui5-rating-indicator]") + .shadow() + .find(".ui5-rating-indicator-item-unsel [ui5-icon]") + .first() + .shadow() + .find("svg") + .should("exist"); + }); + }); + describe("Custom Icons", () => { it("should render default icons when no custom icons are specified", () => { cy.mount(); diff --git a/packages/main/src/RatingIndicator.ts b/packages/main/src/RatingIndicator.ts index b88e2bf454a09..4a2b47403e947 100644 --- a/packages/main/src/RatingIndicator.ts +++ b/packages/main/src/RatingIndicator.ts @@ -17,6 +17,8 @@ import { import { getEffectiveAriaLabelText } from "@ui5/webcomponents-base/dist/util/AccessibilityTextsHelper.js"; import i18n from "@ui5/webcomponents-base/dist/decorators/i18n.js"; import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js"; +import "@ui5/webcomponents-icons/dist/favorite.js"; +import "@ui5/webcomponents-icons/dist/unfavorite.js"; import { RATING_INDICATOR_TEXT, RATING_INDICATOR_TOOLTIP_TEXT, From 388fa1c5f1adbdf8380ed9fde60a2ad1db0173ac Mon Sep 17 00:00:00 2001 From: Nikolay Deshev Date: Wed, 15 Jul 2026 17:05:33 +0300 Subject: [PATCH 2/2] fix(ui5-rating-indicator): import default icons fix the test --- packages/main/cypress/specs/RatingIndicator.cy.tsx | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/packages/main/cypress/specs/RatingIndicator.cy.tsx b/packages/main/cypress/specs/RatingIndicator.cy.tsx index 4ee1d933264fe..5646cd4b4c56b 100644 --- a/packages/main/cypress/specs/RatingIndicator.cy.tsx +++ b/packages/main/cypress/specs/RatingIndicator.cy.tsx @@ -15,16 +15,22 @@ describe("RatingIndicator", () => { .find(".ui5-rating-indicator-item-sel [ui5-icon]") .first() .shadow() - .find("svg") - .should("exist"); + .find("svg path[d]") + .should("exist") + .and($path => { + expect($path.attr("d")).to.have.length.greaterThan(0); + }); cy.get("[ui5-rating-indicator]") .shadow() .find(".ui5-rating-indicator-item-unsel [ui5-icon]") .first() .shadow() - .find("svg") - .should("exist"); + .find("svg path[d]") + .should("exist") + .and($path => { + expect($path.attr("d")).to.have.length.greaterThan(0); + }); }); });