Skip to content

deduplicate control telemetry sender protocol details #33

@lindestad

Description

@lindestad

Follow-up from the uv migration PR review: #30

Copilot noted that tools/send_control_telemetry.py duplicates control telemetry protocol details that already live in the runtime code:

  • local AXES definition instead of lib.control_telemetry.AXES
  • local PORT = 5005 instead of CONTROL_TELEM_PORT
  • binascii.crc32 instead of the shared lib.crc.crc32_ieee
  • hardcoded expected packet size instead of PACKET_SIZE

This predates the uv migration because the script was moved from tests/test_control_telemetry.py, so it should be fixed separately from the dependency-management PR.

Suggested fix: update the standalone sender to import the shared protocol constants and CRC helper from the app code, then verify it still emits the expected 80-byte packet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions