From b09a91a1ddb68f308807a80d3fd98e3c123f7fed Mon Sep 17 00:00:00 2001 From: Jacob Pratt Date: Tue, 7 Oct 2025 22:10:53 +0200 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=A4=96=20Merge=20PR=20#73849=20reveal?= =?UTF-8?q?.js:=20include=20config=20fields=20from=20notes=20plugin=20by?= =?UTF-8?q?=20@jhpratt?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- types/reveal.js/plugin/notes/notes.esm.d.ts | 7 +++++++ types/reveal.js/plugin/notes/notes/index.d.ts | 7 +++++++ types/reveal.js/reveal.esm.js-tests.ts | 2 ++ types/reveal.js/reveal.js-tests.ts | 2 ++ 4 files changed, 18 insertions(+) diff --git a/types/reveal.js/plugin/notes/notes.esm.d.ts b/types/reveal.js/plugin/notes/notes.esm.d.ts index 06ca51e7c3fc40..2e24430f849182 100644 --- a/types/reveal.js/plugin/notes/notes.esm.d.ts +++ b/types/reveal.js/plugin/notes/notes.esm.d.ts @@ -8,3 +8,10 @@ import Reveal = require("../../."); declare const RevealNotes: Reveal.PluginFunction; export = RevealNotes; + +declare module "reveal.js" { + interface Options { + totalTime?: number | undefined; + minTimePerSlide?: number | undefined; + } +} diff --git a/types/reveal.js/plugin/notes/notes/index.d.ts b/types/reveal.js/plugin/notes/notes/index.d.ts index d894bc74fb602a..396c70456f9b8d 100644 --- a/types/reveal.js/plugin/notes/notes/index.d.ts +++ b/types/reveal.js/plugin/notes/notes/index.d.ts @@ -8,3 +8,10 @@ import Reveal = require("../../../."); declare const RevealNotes: Reveal.PluginFunction; export = RevealNotes; + +declare module "reveal.js" { + interface Options { + totalTime?: number | undefined; + minTimePerSlide?: number | undefined; + } +} diff --git a/types/reveal.js/reveal.esm.js-tests.ts b/types/reveal.js/reveal.esm.js-tests.ts index b3443d97e6dbf4..b2335e6a30128a 100644 --- a/types/reveal.js/reveal.esm.js-tests.ts +++ b/types/reveal.js/reveal.esm.js-tests.ts @@ -461,6 +461,8 @@ deck.configure({}); // $ExpectType void deck.configure({ slideNumber: true, width: 20, height: 20 }); +deck.configure({ totalTime: 0, minTimePerSlide: 0 }); + // -------------- // // destroy method // // -------------- // diff --git a/types/reveal.js/reveal.js-tests.ts b/types/reveal.js/reveal.js-tests.ts index 7dec94c7a1c001..3ebe0c2f6d3bea 100644 --- a/types/reveal.js/reveal.js-tests.ts +++ b/types/reveal.js/reveal.js-tests.ts @@ -499,6 +499,8 @@ deck.configure({ controls: "speaker-only" }); // @ts-expect-error deck.configure({ controls: "foo" }); +deck.configure({ totalTime: 0, minTimePerSlide: 0 }); + // -------------- // // destroy method // // -------------- // From ac1acf965f539e4a9f7ac38bd268675793ded4c1 Mon Sep 17 00:00:00 2001 From: Sam Ramon <15154970+samantharamon@users.noreply.github.com> Date: Tue, 7 Oct 2025 14:28:13 -0700 Subject: [PATCH 2/2] [office-js-preview] (Outlook) Document the contentId property for inline attachments (#73800) --- types/office-js-preview/index.d.ts | 18 ++++++++++++++++++ types/office-js/index.d.ts | 16 ++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/types/office-js-preview/index.d.ts b/types/office-js-preview/index.d.ts index 88ff58e4a342bc..3bc116665372a3 100644 --- a/types/office-js-preview/index.d.ts +++ b/types/office-js-preview/index.d.ts @@ -12978,6 +12978,24 @@ declare namespace Office { * `Office.MailboxEnums.AttachmentType.File`. The file name extension is returned in the `name` property. */ attachmentType: MailboxEnums.AttachmentType | string; + /** + * Gets the content identifier of an inline attachment. + * + * @remarks + * + * **Important**: + * + * - The `contentId` property is only supported in Outlook on the web and the new Outlook on Windows. + * + * - Starting November 15, 2025, changes to how inline images are represented in the HTML body of Outlook emails in + * Outlook on the web and the new Outlook on Windows will begin rolling out to production users. + * Previously, the attachment ID of the image appeared in the `src` attribute of the applicable `` element. + * After the change, the image will be represented by a content ID (`cid`) in the `src` attribute instead. + * As a result, you'll need to update your add-in's parsing logic if you parse the attachment ID from the HTML editor or + * get the Base64 value of the image from the URL in the `src` attribute. For more information, see + * {@link https://devblogs.microsoft.com/microsoft365dev/changes-to-inline-images-in-outlook | Changes to inline image representation in Outlook on the web and new Outlook for Windows}. + */ + contentId: string; /** * Gets the index of the attachment. */ diff --git a/types/office-js/index.d.ts b/types/office-js/index.d.ts index 677cb07ba4e9e5..4359f369262f5b 100644 --- a/types/office-js/index.d.ts +++ b/types/office-js/index.d.ts @@ -12933,6 +12933,22 @@ declare namespace Office { * `Office.MailboxEnums.AttachmentType.File`. The file name extension is returned in the `name` property. */ attachmentType: MailboxEnums.AttachmentType | string; + /** + * Gets the content identifier of an inline attachment. + * + * **Important**: + * + * - The `contentId` property is only supported in Outlook on the web and the new Outlook on Windows. + * + * - Starting November 15, 2025, changes to how inline images are represented in the HTML body of Outlook emails in + * Outlook on the web and the new Outlook on Windows will begin rolling out to production users. + * Previously, the attachment ID of the image appeared in the `src` attribute of the applicable `` element. + * After the change, the image will be represented by a content ID (`cid`) in the `src` attribute instead. + * As a result, you'll need to update your add-in's parsing logic if you parse the attachment ID from the HTML editor or + * get the Base64 value of the image from the URL in the `src` attribute. For more information, see + * {@link https://devblogs.microsoft.com/microsoft365dev/changes-to-inline-images-in-outlook | Changes to inline image representation in Outlook on the web and new Outlook for Windows}. + */ + contentId: string; /** * Gets the index of the attachment. */