From 62937f5cee293f3085ed5693c4c5a55beb3ab74d Mon Sep 17 00:00:00 2001 From: Shunichi Ikegami Date: Mon, 27 Oct 2025 15:35:09 +0900 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=A4=96=20Merge=20PR=20#73971=20feat(r?= =?UTF-8?q?ails=5F=5Factioncable):=20Add=20Consumer.addSubProtocol=20metho?= =?UTF-8?q?d=20by=20@shunichi?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- types/rails__actioncable/index.d.ts | 2 ++ types/rails__actioncable/rails__actioncable-tests.ts | 2 ++ 2 files changed, 4 insertions(+) diff --git a/types/rails__actioncable/index.d.ts b/types/rails__actioncable/index.d.ts index 5d5fe1506f5e1d..7e478d7e45e769 100644 --- a/types/rails__actioncable/index.d.ts +++ b/types/rails__actioncable/index.d.ts @@ -18,11 +18,13 @@ export const adapters: { */ export class Consumer { readonly subscriptions: Subscriptions; + readonly subprotocols: string[]; constructor(url: string); get url(): string; connect(): boolean; disconnect(): void; + addSubProtocol(protocol: string): void; } export interface BaseMixin { diff --git a/types/rails__actioncable/rails__actioncable-tests.ts b/types/rails__actioncable/rails__actioncable-tests.ts index f6339916c68d30..ec2da6e6c4950f 100644 --- a/types/rails__actioncable/rails__actioncable-tests.ts +++ b/types/rails__actioncable/rails__actioncable-tests.ts @@ -9,9 +9,11 @@ const consumer = createConsumer("url"); // $ExpectType Consumer createConsumer(() => "url"); // $ExpectType Consumer consumer.url; // $ExpectType string +consumer.subprotocols; // $ExpectType string[] consumer.connect(); // $ExpectType boolean consumer.disconnect(); // $ExpectType void +consumer.addSubProtocol("custom-protocol"); // $ExpectType void { const subscription = consumer.subscriptions.create( From bc2419bfb1fa3425c1fdf6e06581f3d278f0aa78 Mon Sep 17 00:00:00 2001 From: TypeScript Bot Date: Mon, 27 Oct 2025 08:13:48 +0000 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=A4=96=20Update=20CODEOWNERS?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/CODEOWNERS | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 32460f04a46983..b79d83a2b512da 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -167,6 +167,7 @@ /types/amqp/ @seikho @jonnysparkplugs /types/amqp-rpc/ @wokim /types/amqplib/ @mnahkies @abreits @nfantone @nickzelei @XVincentX @seonggwonyoon +/types/amzn__synthetics-playwright/ @kovacsandor /types/analog-clock/ @ihatecsv /types/analytics-node/ @fongandrew @thomasthiebaud /types/anchor-js/ @xt0rted @@ -1913,7 +1914,7 @@ /types/exit/ @Bartvds /types/exorcist/ @TeamworkGuy2 @BendingBender /types/expand-tilde/ @carnesen -/types/expect-cookies/ @dmurvihill +/types/expect-cookies/ @dmurvihill @gregl83 /types/expect-puppeteer/ @tkrotoff @jfm710 /types/expect.js/ @teppeis /types/expectations/ @vvakame @@ -3540,7 +3541,7 @@ /types/jalaali-js/ @alitaheri /types/japanese-characters/ @peterblazejewicz /types/japanese-holidays/ @syamatoo @peterblazejewicz -/types/jasmine/ @borisyankov @theodorejb @lukas-zech-software @Engineer2B @cyungmann @Roaders @devoto13 @fdim @kolodny @stephenfarrar @djungowski @chivesrs @kirjs @Semigradsky +/types/jasmine/ @borisyankov @theodorejb @lukas-zech-software @Engineer2B @cyungmann @Roaders @fdim @kolodny @stephenfarrar @djungowski @chivesrs @kirjs @Semigradsky /types/jasmine/v1/ @borisyankov /types/jasmine/v2/ @borisyankov @theodorejb @davidparsson @gmoothart @lukas-zech-software @Engineer2B @cyungmann @devoto13 @fdim /types/jasmine/v3/ @borisyankov @theodorejb @davidparsson @lukas-zech-software @Engineer2B @cyungmann @Roaders @devoto13 @fdim @kolodny @stephenfarrar @djungowski @chivesrs @kirjs @Semigradsky @@ -4762,7 +4763,7 @@ /types/mcping-js/ @Inrixia /types/mcrypt/ @pluma /types/mcustomscrollbar/ @flurg -/types/md5/ @arcdev1 @jprogrammer @peterblazejewicz @DethAriel +/types/md5/ @arcdev1 @peterblazejewicz @DethAriel /types/mdast/ @ChristianMurphy @lujun2 @remcohaszing @wooorm @remcohaszing /types/mdast/v3/ @ChristianMurphy @lujun2 @remcohaszing @wooorm /types/mdns/ @reppners @@ -5443,7 +5444,7 @@ /types/optimist/ @soywiz @chbrown /types/optimize-css-assets-webpack-plugin/ @odnamrataizem @skovy /types/oracle__oraclejet/ @nolakara @jingxwu -/types/oracledb/ @connorjayfitzgerald @dannyb648 @jacobwheale @hjamil-24 @sharadraju +/types/oracledb/ @connorjayfitzgerald @dannyb648 @jacobwheale @sudarshan12s @sharadraju /types/oracledb/v3/ @Bigous @connorjayfitzgerald /types/orchestrator/ @tkQubo @TeamworkGuy2 /types/orientjs/ @saeedtabrizi @aleksey-rezvov @@ -6016,7 +6017,7 @@ /types/radix64/ @huan086 /types/raf/ @BenLorantfy /types/raf-schd/ @adambrgmn -/types/rails__actioncable/ @martin-badin +/types/rails__actioncable/ @martin-badin @shunichi /types/rails__activestorage/ @imustafin @cbothner /types/rails__request.js/ @alexandergitter /types/rails__ujs/ @fsubal @abcang @@ -7700,7 +7701,7 @@ /types/tabulator-tables/ @jojoshua @mike-lischke /types/tadashi__koa-jwt-authz/ @Shqrp /types/tail/ @spacejack @devindavies -/types/tampermonkey/ @silverwzw @nikolay-borzov @taozhiyu @double-beep +/types/tampermonkey/ @silverwzw @nikolay-borzov @taozhiyu @double-beep @ziuchen /types/tapable/ @e-cloud @johnnyreilly /types/tapable/v0/ @e-cloud /types/tapable/v1/ @e-cloud @johnnyreilly @@ -8436,7 +8437,7 @@ /types/wordfilter/ @mlc /types/wordpress-hash-node/ @glennreyes /types/wordpress__admin/ @oblakstudio -/types/wordpress__block-editor/ @dsifford @sirreal @dmsnell +/types/wordpress__block-editor/ @dsifford @sirreal @dmsnell @joshualip-plaudit /types/wordpress__block-library/ @dsifford /types/wordpress__block-serialization-spec-parser/ @dsifford /types/wordpress__blocks/ @dsifford @sirreal @dmsnell @tomasztunik @sunyatasattva @bastolen