Skip to content

Commit 93a7d71

Browse files
update
One more time... just running the UnifiedNetworkTransformTest for this phase. A more integrated one will be coming in the next PR for this effort.
1 parent 9e8b6bb commit 93a7d71

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

.yamato/project.metafile

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,16 @@ unified_test_platforms:
227227
# The other jobs' "Unity.Netcode.RuntimeTests.*" works because it is also a valid regex - it just
228228
# happens to read like a glob.
229229
#
230-
# The match is against the NUnit *full* test name, which includes fixture arguments. That covers both
231-
# the dedicated unified fixtures (UnifiedNetworkTransformTest) and any shared fixture parameterized
232-
# with HostOrServer.UnifiedHost / UnifiedServer, e.g. "NetworkTransformTests(UnifiedHost,...)".
233-
unified_test_filter: ".*Unified.*"
230+
# The match is against the NUnit *full* test name, which includes both fixture and method arguments.
231+
#
232+
# DO NOT widen this to ".*Unified.*". "Unified" appearing in a test name does NOT mean that test was
233+
# deliberately converted to run against hybrid prefabs. HostOrServer gained UnifiedServer/UnifiedHost
234+
# members under UNIFIED_NETCODE, and NUnit expands a bare [Values] on an enum parameter (and
235+
# enum-typed fixture constructors) to every member. So with N4E installed, much of the existing suite
236+
# silently grows unified cases - e.g. NetworkVariableTests(Default).AllNetworkVariableTypes(UnifiedHost),
237+
# which nobody wrote. ".*Unified.*" selected 138 tests, 84 of which failed, against the 1 test this
238+
# job exists to validate. Deciding which of those should pass, and how they opt in, is Goal-2.
239+
unified_test_filter: ".*UnifiedNetworkTransformTest.*"
234240

235241

236242
# Scripting backends used by Standalone RunTimeTests---------------------------------------------------

0 commit comments

Comments
 (0)