Fix test + remove not reachable code

Author: noellie-velez

com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs

@@ -1856,6 +1856,8 @@ internal void HandleNetworkObjectShow(bool forceSend = false)
                 {
                     if (entry.Key != null && entry.Key.IsSpawned)
                     {
+                        // Try catch due to ensure that if anything throws we keep processing the list.
+                        // This can throw if the GameObject was destroyed on this frame.
                         try
                         {
                             // Always push the most recent deltas when showing a NetworkObject
@@ -1885,6 +1887,8 @@ internal void HandleNetworkObjectShow(bool forceSend = false)
                 {
                     if (networkObject != null && networkObject.IsSpawned)
                     {
+                        // Try catch due to ensure that if anything throws we keep processing the list.
+                        // This can throw if the GameObject was destroyed on this frame.
                         try
                         {
                             if (forceSend)
@@ -2019,10 +2023,6 @@ internal void DistributeNetworkObjects(ulong clientId)
         {
             if (!NetworkManager.DistributedAuthorityMode)
             {
-                if (NetworkManager.LogLevel <= LogLevel.Error)
-                {
-                    NetworkLog.LogError("[DistributeNetworkObjects] called while not in Distributed Authority Mode!");
-                }
                 return;
             }
 
@@ -2285,12 +2285,6 @@ internal void NotifyNetworkObjectsSynchronized()
         /// </remarks>
         internal void ShowHiddenObjectsToNewlyJoinedClient(ulong newClientId)
         {
-            if (NetworkManager == null || NetworkManager.ShutdownInProgress && NetworkManager.LogLevel <= LogLevel.Developer)
-            {
-                NetworkLog.LogWarning($"[Internal Error] {nameof(ShowHiddenObjectsToNewlyJoinedClient)} invoked while shutdown is in progress!");
-                return;
-            }
-
             if (!NetworkManager.DistributedAuthorityMode)
             {
                 if (NetworkManager.LogLevel <= LogLevel.Error)
@@ -2332,12 +2326,6 @@ internal void ShowHiddenObjectsToNewlyJoinedClient(ulong newClientId)
 
         internal void SynchronizeObjectsToNewlyJoinedClient(ulong newClientId)
         {
-            if (NetworkManager == null || NetworkManager.ShutdownInProgress && NetworkManager.LogLevel <= LogLevel.Developer)
-            {
-                NetworkLog.LogWarning($"[Internal Error] {nameof(SynchronizeObjectsToNewlyJoinedClient)} invoked while shutdown is in progress!");
-                return;
-            }
-
             if (!NetworkManager.DistributedAuthorityMode)
             {
                 if (NetworkManager.LogLevel <= LogLevel.Error)

com.unity.netcode.gameobjects/Tests/Runtime/NetworkSpawnManagerTests.cs

@@ -100,10 +100,9 @@ public void TestClientCantAccessOtherPlayer()
             }
 
             // client can't access other player
-            Assert.Throws<NotServerException>(() =>
-            {
-                m_ClientNetworkManagers[0].SpawnManager.GetPlayerNetworkObject(otherClientSideClientId);
-            });
+            string expectedLog = $"[Netcode-Server Sender=0] {otherClientSideClientId} Only the server can find player objects from other clients.";
+            LogAssert.Expect(UnityEngine.LogType.Error, expectedLog);
+            m_ClientNetworkManagers[0].SpawnManager.GetPlayerNetworkObject(otherClientSideClientId);
         }
 
         [Test]