Skip to content

OAuth signature not matched when data is url encoded #205

Description

@drsdre

This subject has been discussed several times before, but the current solution is not correct yet for POST requests.

The situation:
I'm updating a WP record which includes a URL post field like:
url=http://siteurl.com/page?key=xxxyyy%3D (the string '%3D' needs to be preserved)

When the Oauth1 plugin processes the data, it receives the following post data:
Array
(
[url] => http://siteurl.com/page?key=xxxyyy%3D
)

However when it passes through the normalize_parameters function it creates the following data:
Array
(
[url] => http%3A%2F%2Fsiteurl.com%2Fpage%3Fkey%3Dxxxyyy%3D
)

(this decodes back into http://siteurl.com/page?key=xxxyyy= (instead of %3D).

Expected is:
Array
(
[url] => http%3A%2F%2Fsiteurl.com%2Fpage%3Fkey%3Dxxxyyy%253D
)

(this decodes back into http://siteurl.com/page?key=xxxyyy%3D).

Conclusion:
For POST data, the normalize_function should NOT rawurldecode the parameters as this is changing the incoming data hence the Oauth1 signature will not match anymore.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions