Merge pull request #114 from WarehouseFinds/feat/last_review

Add matrix.os for Unit Tests

Author: marko-stanojevic

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,2 +1,13 @@
+# Description
+
 <!-- Provide a brief description of the changes in this PR -->
-<!-- tip: use GitHub Copilot to generate description -->
+<!-- tip: use GitHub Copilot to generate description -->
+
+## Type of Change
+
+<!-- Select one by placing an 'x' in the brackets -->
+- [ ] Bug fix
+- [ ] New feature
+- [ ] Breaking change
+- [ ] Documentation update
+- [ ] Code quality improvement (refactoring, tests, performance)

.github/workflows/powershell-script-module-analysis-unit-tests.yml

@@ -14,7 +14,12 @@ jobs:
       pull-requests: write
       checks: write
     name: Pester
-    runs-on: [ubuntu-latest]
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+    # We need to run on Ubuntu, Windows and MacOS to ensure cross-platform compatibility
+    # Using matrix strategy to define OSes
+    runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 #v6.01
@@ -35,6 +40,7 @@ jobs:
           Invoke-Build -Task Invoke-UnitTests
 
       - name: Publish Unit Test Results
+        if: matrix.os == 'ubuntu-latest'
         uses: EnricoMi/publish-unit-test-result-action@27d65e188ec43221b20d26de30f4892fad91df2f #v2.22.0
         with:
           job_summary: true
@@ -45,12 +51,14 @@ jobs:
             test-results/unit-tests.xml
 
       - name: Setup .NET Core for ReportGenerator
+        if: matrix.os == 'ubuntu-latest'
         uses: actions/setup-dotnet@baa11fbfe1d6520db94683bd5c7a3818018e4309 #v5.1
         with:
           dotnet-version: 10.x
           dotnet-quality: 'ga'
 
       - name: Run ReportGenerator on Code Coverage Report
+        if: matrix.os == 'ubuntu-latest'
         uses: danielpalme/ReportGenerator-GitHub-Action@ee0ae774f6d3afedcbd1683c1ab21b83670bdf8e #5.5.1
         with:
           reports: 'test-results/codecoverage/code-coverage.xml'
@@ -62,10 +70,11 @@ jobs:
           toolpath: 'reportgeneratortool'
 
       - name: Publish code coverage summary
-        shell: bash
+        if: matrix.os == 'ubuntu-latest'  # Only need to publish once
         run: cat test-results/codecoverage/report/SummaryGithub.md >> $GITHUB_STEP_SUMMARY
 
       - name: Upload coverage report artifact
+        if: matrix.os == 'ubuntu-latest'
         uses: actions/upload-artifact@v6
         with:
           name: CoverageReport

.github/workflows/powershell-script-module-cache-dependencies.yml

@@ -1,16 +1,16 @@
-name: '[template] PS Cache Dependencies'
+name: '[template] PS Resolve Dependencies'
 permissions: read-all
 on:
   workflow_call:
     outputs:
       module-list: 
         description: 'Comma-separated list of PowerShell modules to install and cache'
-        value: ${{ jobs.setup-powershell-dependencies.outputs.module-list }}
+        value: ${{ jobs.resolve-powershell-dependencies.outputs.module-list }}
 
 jobs:
-  setup-powershell-dependencies:
+  resolve-powershell-dependencies:
     name: Dependencies
-    runs-on: [ubuntu-latest]
+    runs-on: ubuntu-latest
     outputs:
       module-list: ${{ steps.resolve-dependencies.outputs.module-list }}
     steps:
@@ -23,7 +23,6 @@ jobs:
         id: resolve-dependencies
         shell: pwsh
         run: |
-          # Resolve module dependencies from requirements.psd1
           $moduleRequirements = Import-PowerShellDataFile -Path './requirements.psd1'
           $moduleList = foreach ($module in $moduleRequirements.GetEnumerator()) {
               $moduleName = $module.Key
@@ -45,20 +44,3 @@ jobs:
           }
           $moduleList = $moduleList | Sort-Object | Join-String -Separator ','
           "module-list=$moduleList" | Out-File -FilePath $env:GITHUB_OUTPUT -Append
-
-      - name: Install and cache PowerShell modules
-        uses: potatoqualitee/psmodulecache@ee5e9494714abf56f6efbfa51527b2aec5c761b8 #v6.2.1
-        with:
-          modules-to-cache: ${{ steps.resolve-dependencies.outputs.module-list }}
-          shell: pwsh
-          updatable: false
-
-      - name: Verify installed modules
-        shell: pwsh
-        run: |
-          # Verify that required modules are installed
-          $moduleRequirements = Import-PowerShellDataFile -Path './requirements.psd1'
-          foreach ($moduleName in $moduleRequirements.Keys) {
-              Get-Module -ListAvailable -Name $moduleName -ErrorAction Stop
-          }
-