From a6a2cf4c4a09e3fb55d3174cb5ae47798b366b62 Mon Sep 17 00:00:00 2001 From: Matthew P Munger Date: Mon, 31 Aug 2026 16:15:13 -0500 Subject: [PATCH] docs: move the Ora repair row to Landed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit REPAIRS.md's own rule: "When it lands, move the row to Landed." It landed in #98 as `5e6da97`, merged to `main` as `9733e8e`, so the row saying it is claimed and in flight is now the one thing this file exists to prevent — the next session reading it would hold off on a defect that is already fixed. The claim line takes the shape the other Landed rows use (branch / PR — sha), and gains the base it was seen at and the sha it landed as. The symptom moves to past tense, because it is now a record of a defect rather than a report of one. Nothing about the finding itself is edited. The cause — an HTML entity in the same text node, not a leading space in JSX — is the part worth keeping, and it is why the row is long. Co-Authored-By: Claude Opus 5 --- REPAIRS.md | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/REPAIRS.md b/REPAIRS.md index ea5e416..c320759 100644 --- a/REPAIRS.md +++ b/REPAIRS.md @@ -91,19 +91,24 @@ one commit. there, not to copy it — two statements of one retention rule is the drift that put it in the wrong place to begin with. +## Landed + ### The Ora note runs two sentences together on screen - **Found by:** C3, on `chunk-c3`, while merging `origin/main` (`07834fa`). - **Left open by C3, deliberately.** It is a one-character change in a line C3 also edits, which is exactly the shape R3 warns about: a shared defect buried in a feature diff cannot be reviewed or reverted on its own. -- **Claimed by:** `ui-improvements-post-refactor`, at base `98177fc`. +- **Claimed by:** `ui-improvements-post-refactor` / #98 — `5e6da97` +- **Seen at:** `98177fc` (`main`), the base the branch was cut from. +- **Landed:** merged as `9733e8e`. `main` was green on lint, typecheck, + test and build at that sha. - **Symptom:** in `settings/page.tsx`, `{SETTINGS_SYSTEM_CONTRIBUTES.ora}` is followed by ` Switching it on sends...` on the same line, and the leading space is dropped. The rendered note reads "...you have to switch on.Switching it on sends...", with the DOM showing `switch on.Switching`. Introduced by S9 (#93); no check reads rendered - copy, so CI is green on it. + copy, so CI was green on it throughout. - **Cause — not what the symptom looks like.** "JSX drops a leading space" is not true, and a session that believes it will go looking for the wrong thing. JSX keeps the leading space on the first line of a text node; four probe @@ -125,8 +130,6 @@ one commit. the next line. Verified in the rendered DOM, not just the diff: `switch on. Switching`. -## Landed - ### Conflict markers committed into `DECISIONS.md` - **Claimed by:** `fix/decisions-conflict-markers` / #91 — `d00940c`