Outlines are hidden by 'hide UI'

[sprunk]

I feel like they are part of game/unit aesthetics and not UI, so shouldn't be disabled.

[strategineer]

By going to Settings -> Graphics -> Unit Visibility -> Outline you can set this with the option: "Disable with hidden UI". It's implemented here https://github.com/ZeroK-RTS/Zero-K/blob/master/LuaUI/Widgets/gfx_outline_shader_gl4.lua#L147

There are other gfx_outline_shader_* files but they don't seem to be enabled / in-use at least in my setup.

I tested it the option by unchecking it and it works as expected by retaining the outline even when the UI is hidden. See screenshots below.

The option defaults to true, would we want to set it to false by default?

Another choice would be to remove the option entirely?

[strategineer]

I did some more testing. When starting a new game, hiding the UI hides the unit outlines no matter how the option is set.

Going into the options again and checking it and unchecking it solves the issue.

EDIT: Ignore all this. I think me changing the default value to false led to this weird behavior.

[strategineer]

PR to remove the option entirely: #5615

PR to set the option to not hide the unit outlines by default: #5614