Skip to content

Commit dc342e7

Browse files
committed
chore: remove unused js functions
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
1 parent da59357 commit dc342e7

5 files changed

Lines changed: 111 additions & 160 deletions

File tree

vulnerabilities/pipelines/v2_improvers/compute_advisory_todo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ def get_disagreement_message(fixed_disagreement, affected_disagreement):
518518

519519
messages.append(f"Advisories do not agree whether {noun} {fixed} {verb} the fix.")
520520

521-
return " ".join(messages)
521+
return "\n".join(messages)
522522

523523

524524
def get_grouped_curation_advisories_for_dashboard_ui(purl, adv_map, conflict_detail, advisories):

vulnerabilities/templates/package_curation.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@
1111
<div class="container is-fluid">
1212
<div class="columns is-vcentered mb-5">
1313
<div class="column">
14-
<h1 class="title is-3">Curation Dashboard</h1>
14+
<h1 class="title is-3">Advisory Curation</h1>
1515
<h2 class="subtitle is-5 has-text-grey">{{ vulnerability_id }}</h2>
1616
</div>
1717

1818
<div class="column is-narrow">
1919
<div class="box p-4 has-background-white shadow-soft" style="min-width: 260px; border-radius: 5px;">
2020
<div class="is-flex is-justify-content-space-between is-align-items-center mb-2">
21-
<span class="is-size-7 has-text-grey-dark uppercase has-text-weight-bold mr-2 mt-1">
21+
<span class="is-size-6 has-text-grey-dark uppercase has-text-weight-bold mr-2">
2222
Progress
2323
</span>
2424
<span class="tag is-info is-light has-text-weight-bold" id="progress-text">0 / 0</span>
2525
</div>
26-
<progress class="progress is-info is-small mb-0" id="main-progress" value="0" max="100"></progress>
26+
<progress class="progress is-info is-small mb-0" id="progress" value="0" max="100"></progress>
2727
</div>
2828
</div>
2929

@@ -36,7 +36,7 @@ <h3 class="title is-5">Advisory Summaries</h3>
3636
{% for avid, text in advisory_summaries.items %}
3737
<div class="notification is-info is-light p-3 mb-3">
3838
<p><strong>{{ avid }}</strong></p>
39-
<div class="summary-text">{{ text|normalize_links|urlize }}</div>
39+
<div class="text summary-text is-2">{{ text|normalize_links|urlize }}</div>
4040
</div>
4141
{% empty %}
4242
<div class="notification is-light p-3 mb-3 has-text-grey">
@@ -50,7 +50,7 @@ <h3 class="title is-5">Advisory Summaries</h3>
5050
<div class="box">
5151
<div class="mb-4">
5252
<h4 class="title is-4 mb-1" id="current-purl"></h4>
53-
<p class="help" id="conflict-reason"></p>
53+
<p class="text is-5" id="conflict-reason"></p>
5454
</div>
5555

5656
<div class="table-container" style="max-height: 800px; overflow-y: auto; border: 1px solid #dbdbdb; border-radius: 6px;">
@@ -80,7 +80,7 @@ <h4 class="title is-4 mb-1" id="current-purl"></h4>
8080
</button>
8181
<button class="button is-info is-hidden" id="finish-btn" disabled>
8282
<span class="icon"><i class="fa fa-check"></i></span>
83-
<span>Validate</span>
83+
<span>Submit</span>
8484
</button>
8585
</div>
8686
</div>
@@ -98,4 +98,4 @@ <h4 class="title is-4 mb-1" id="current-purl"></h4>
9898
const curationItems = {{ curation_items|safe }};
9999
</script>
100100
<script src="{% static 'js/package_curation.min.js' %}"></script>
101-
{% endblock %}
101+
{% endblock %}

vulnerablecode/static/css/package_curation.css

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,6 @@
4545
width: 100px !important;
4646
}
4747

48-
49-
.curation-cell,
50-
.advisory-cell,
51-
#curation-body td,
52-
.folded-row-marker,
53-
.range-data-cell,
54-
.help-instructions {
55-
font-size: 0.8rem !important;
56-
}
57-
5848
.curation-cell {
5949
cursor: pointer;
6050
text-align: center !important;
@@ -74,12 +64,6 @@
7464
cursor: not-allowed;
7565
}
7666

77-
.advisory-cell {
78-
text-align: center !important;
79-
vertical-align: middle !important;
80-
border: 1px solid #dbdbdb !important;
81-
}
82-
8367
.folded-row-marker,
8468
.range-row-marker {
8569
cursor: pointer;
@@ -89,30 +73,10 @@
8973
background-color: #f5f5f5;
9074
}
9175

92-
.folded-row-marker {
93-
height: 30px;
94-
}
95-
96-
.folded-row-marker:hover,
97-
.range-row-marker:hover {
98-
background-color: #ededed;
99-
color: #0a0a0a;
100-
}
101-
102-
.folded-row-marker .icon {
103-
transition: transform 0.2s ease;
104-
}
105-
10676
.folded-row-marker.is-expanded .icon {
10777
transform: rotate(180deg);
10878
}
10979

110-
.range-row-marker {
111-
font-size: 0.8rem;
112-
padding: 6px 0;
113-
border: 1px solid #dbdbdb !important;
114-
}
115-
11680
.range-data-cell {
11781
background-color: #fafafa;
11882
padding: 6px !important;
@@ -133,7 +97,6 @@
13397
}
13498

13599
.summary-text {
136-
font-size: 0.85rem;
137100
line-height: 1.4;
138101
white-space: pre-wrap;
139102
word-break: break-word;
@@ -167,8 +130,3 @@
167130
white-space: normal;
168131
flex-wrap: wrap;
169132
}
170-
171-
.advisory-link .icon {
172-
font-size: 0.75rem;
173-
flex-shrink: 0;
174-
}

0 commit comments

Comments
 (0)