fix: set default value to true to not have to transport the unzip: true when not needed

Author: shiipou

packages/artifact/__tests__/download-artifact.test.ts

@@ -179,8 +179,7 @@ describe('download-artifact', () => {
         fixtures.artifactID,
         fixtures.repositoryOwner,
         fixtures.repositoryName,
-        fixtures.token,
-        {unzip: true}
+        fixtures.token
       )
 
       expect(downloadArtifactMock).toHaveBeenCalledWith({
@@ -224,8 +223,7 @@ describe('download-artifact', () => {
         fixtures.artifactID,
         fixtures.repositoryOwner,
         fixtures.repositoryName,
-        fixtures.token,
-        {unzip: true}
+        fixtures.token
       )
 
       expect(downloadArtifactMock).toHaveBeenCalledWith({
@@ -282,8 +280,7 @@ describe('download-artifact', () => {
         fixtures.repositoryName,
         fixtures.token,
         {
-          path: customPath,
-          unzip: true
+          path: customPath
         }
       )
 
@@ -319,8 +316,7 @@ describe('download-artifact', () => {
           fixtures.artifactID,
           fixtures.repositoryOwner,
           fixtures.repositoryName,
-          fixtures.token,
-          {unzip: true}
+          fixtures.token
         )
       ).rejects.toBeInstanceOf(Error)
 
@@ -358,7 +354,7 @@ describe('download-artifact', () => {
       )
 
       await expect(
-        streamExtractExternal(fixtures.blobStorageUrl, fixtures.workspaceDir, {unzip: true})
+        streamExtractExternal(fixtures.blobStorageUrl, fixtures.workspaceDir)
       ).rejects.toBeInstanceOf(Error)
 
       expect(mockHttpClient).toHaveBeenCalledWith(getUserAgentString())
@@ -389,8 +385,7 @@ describe('download-artifact', () => {
           fixtures.artifactID,
           fixtures.repositoryOwner,
           fixtures.repositoryName,
-          fixtures.token,
-          {unzip: true}
+          fixtures.token
         )
       ).rejects.toBeInstanceOf(Error)
 
@@ -438,8 +433,7 @@ describe('download-artifact', () => {
         fixtures.artifactID,
         fixtures.repositoryOwner,
         fixtures.repositoryName,
-        fixtures.token,
-        {unzip: true}
+        fixtures.token
       )
 
       expect(downloadArtifactMock).toHaveBeenCalledWith({
@@ -557,7 +551,7 @@ describe('download-artifact', () => {
         }
       )
 
-      const response = await downloadArtifactInternal(fixtures.artifactID, {unzip: true})
+      const response = await downloadArtifactInternal(fixtures.artifactID)
 
       expectExtractedArchive(fixtures.workspaceDir)
       expect(response.downloadPath).toBe(fixtures.workspaceDir)
@@ -607,8 +601,7 @@ describe('download-artifact', () => {
       )
 
       const response = await downloadArtifactInternal(fixtures.artifactID, {
-        path: customPath,
-        unzip: true
+        path: customPath
       })
 
       expectExtractedArchive(customPath)
@@ -632,7 +625,7 @@ describe('download-artifact', () => {
         .mockRejectedValue(new Error('boom'))
 
       await expect(
-        downloadArtifactInternal(fixtures.artifactID, {unzip: true})
+        downloadArtifactInternal(fixtures.artifactID)
       ).rejects.toBeInstanceOf(Error)
     })
 
@@ -667,7 +660,7 @@ describe('download-artifact', () => {
       )
 
       await expect(
-        downloadArtifactInternal(fixtures.artifactID, {unzip: true})
+        downloadArtifactInternal(fixtures.artifactID)
       ).rejects.toBeInstanceOf(Error)
       expect(mockHttpClient).toHaveBeenCalledWith(getUserAgentString())
       expect(mockListArtifacts).toHaveBeenCalledWith({

packages/artifact/src/internal/download/download-artifact.ts

@@ -103,7 +103,7 @@ export async function streamExtractExternal(
 
     let outputStream: NodeJS.WritableStream;
 
-    if (options?.unzip) {
+    if (options?.unzip ?? true) {
       outputStream = unzip.Extract({ path: directory });
     } else {
       const fileName = `${options?.artifactName ?? 'artifact'}.zip`;

packages/artifact/src/internal/shared/interfaces.ts

@@ -115,7 +115,7 @@ export interface DownloadArtifactOptions {
   expectedHash?: string,
 
   /**
-   * Whenever to unzip the artifact after download.
+   * Whenever to unzip the artifact after download. Default to true.
    */
   unzip?: boolean
   /**
@@ -130,7 +130,7 @@ export interface StreamExtractOptions {
    */
   timeout: number
   /**
-   * Whenever to unzip the artifact after download.
+   * Whenever to unzip the artifact after download. Default to true.
    */
   unzip?: boolean
   /**