Skip to content

signal_id should be required on SignalDefinition #2192

@bokelley

Description

@bokelley

Problem

signal_id is optional in the SignalDefinition schema, but activate_signal requires signal_agent_segment_id which maps to a signal. Without signal_id, buyers cannot verify signal provenance (marketplace signals need data_provider_domain for adagents.json verification).

The storyboard signal_marketplace checks for signal_id.source and signal_id.data_provider_domain — signals without signal_id fail provenance verification.

Proposal

Make signal_id required on SignalDefinition.

Discovered during storyboard testing in adcontextprotocol/adcp-client#541.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions