adding support for running the search at different sample rates compa…#18
Open
kkacanja wants to merge 3 commits into
Open
adding support for running the search at different sample rates compa…#18kkacanja wants to merge 3 commits into
kkacanja wants to merge 3 commits into
Conversation
ahnitz
reviewed
May 22, 2026
| bank_sample_rate = self.tap_sr | ||
| engine_sample_rate = self.engine_sr | ||
| # Alternatively, determine the downsampling factor directly: | ||
| decimation_factor = int(bank_sample_rate / engine_sample_rate) # e.g., 2048 / 512 = 4 |
Owner
There was a problem hiding this comment.
You might want round here and potentially cause an error if it's not very close to an integer decimation with a warning to explain to the user that they do need to use a power of 2 or at least something that evenly divides.
ahnitz
reviewed
May 22, 2026
Owner
ahnitz
left a comment
ahnitz
left a comment
There was a problem hiding this comment.
I made one minor comment, but otherwise, I think this looks good.
Author
Are you fine with how I named the variables or is there something more intuitive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic of the function remains the same the main difference is utilizing a larger buffer to perform the fft and the reslicing back into desired sample rate done at the end.
This only works for sample rates of the engine that is less than the rate of the tap construction.