chore(convention helper): fixed bugs making impossible to get help

Author: andre-filho

commit_helper/__main__.py

@@ -20,7 +20,7 @@ def main():
 
     debug('file_path', file_path, debug_mode)
 
-    if args.show_convention_tags is not '':
+    if args.show_convention_tags is True:
         convention_help_handler(file_path, args, debug_mode)
         return
 

commit_helper/conventions/convention_help_handler.py

@@ -19,7 +19,7 @@
 # TODO: test
 def convention_help_handler(file_path, args, debug_mode):
     if file_path.is_file() and args.convention is '':
-        debug('Found file', str(file_path), debug_mode)
+        debug('Found file for help', str(file_path), debug_mode)
         with open(str(file_path)) as target:
             try:
                 config = safe_load(target)
@@ -36,24 +36,26 @@ def convention_help_handler(file_path, args, debug_mode):
         print(MIN_ERROR + 'No convention was specified!' + RESET)
         return
 
-    get_help_to_defined_convention(convention)
+    debug('convention captured for helper', convention, debug_mode)
+    get_help_to_defined_convention(convention, debug_mode)
 
 
 # TODO: test
-def get_help_to_defined_convention(convention):
-    if convention is 'angular':
+def get_help_to_defined_convention(convention, debug_mode):
+    debug('recieved convention for help catch', convention, debug_mode)
+    if convention == 'angular':
         print_help(angular_convention_help)
 
-    elif convention is 'tagged':
+    elif convention == 'tagged':
         print_help(tagged_convention_help)
 
-    elif convention is 'karma':
+    elif convention == 'karma':
         print_help(karma_convention_help)
 
-    elif convention is 'symphony':
+    elif convention == 'symphony':
         print_help(symphony_convention_help)
 
-    elif convention is 'atom':
+    elif convention == 'atom':
         print_help(atom_convention_help)
 
     else:

commit_helper/utils/utils.py

@@ -70,7 +70,7 @@ def parser_cli():
                         help='Toggles debug option')
 
     parser.add_argument('-s', '--show', dest='show_convention_tags',
-                        choices=supported_conventions, default='',
+                        default='False', action='store_true',
                         help='Shows the rules of a given convention')
 
     return parser