chore(refactoring): split functions into individual files, reviewed imports and cleans code

Author: andre-filho

conventions/__init__.py

@@ -0,0 +1,7 @@
+from os import system
+from utils import get_text
+
+def changelog_convention():
+    tag, msg = get_text()
+    tag = tag.upper()
+    system("git commit -m '%s: %s'" % (tag, msg))

conventions/changelog.py

@@ -0,0 +1,3 @@
+# FUTURE: implement
+def custom_convention():
+    pass

conventions/custom_convention_handler.py

@@ -0,0 +1,7 @@
+from os import system
+from utils import get_text
+
+def angular_convention():
+    tag, msg, context = get_text(context=True)
+    tag = tag.lower()
+    system("git commit -m '%s(%s): %s'" % (tag, context, msg))

conventions/karma_angular.py

@@ -0,0 +1,6 @@
+from os import system
+from utils import get_text
+
+def just_message():
+    msg = str(input("commit message: "))
+    system("git commit -m '%s'" % msg.capitalize())

conventions/no_convention.py

@@ -0,0 +1,7 @@
+from os import system
+from utils import get_text
+
+def symphony_convention():
+    tag, msg = get_text()
+    tag = tag.capitalize()
+    system("git commit -m '[%s] %s'" % (tag, msg))

conventions/symphony_cmf.py

@@ -2,30 +2,24 @@
 from yaml import safe_load
 from yaml import YAMLError
 
-from utils import run_config
-from utils import angular_convention
-from utils import changelog_convention
-from utils import symphony_convention
-from utils import just_message
-from utils import create_file
+# conventions imports
+from conventions.karma_angular import angular_convention
+from conventions.changelog import changelog_convention
+from conventions.symphony_cmf import symphony_convention
+from conventions.no_convention import just_message
 
-tag = ''
-tag_is_lowercase = False
-tag_is_uppercase = False
-tag_is_capitalized = False
-convention = ''
+from utils import create_file
 
 file_path = Path('commiter.yml')
-
 if file_path.is_file():
     with open(str(file_path), 'r') as stream:
         try:
             config = safe_load(stream)
-            tag, tag_is_capitalized, tag_is_lowercase, tag_is_uppercase, convention = run_config(config, tag, tag_is_capitalized, tag_is_lowercase, tag_is_uppercase, convention)
-            if convention == 'angular':
+            convention = str(config['convention']).lower() if config['convention'] != None else ''
+            if convention == 'angular' or convention == 'karma':
                 print('You are using the %s convention' % convention)
                 angular_convention()
-            elif convention ==  'changelog':
+            elif convention == 'changelog':
                 print('You are using the %s convention' % convention)
                 changelog_convention()
             elif convention == 'symphony':
@@ -37,7 +31,6 @@
                 custom_convention()
         except YAMLError as exc:
             print(exc)
-
 else:
     print("No config files found!\nRunning default script...")
     opt = int(input("""

generator.py

@@ -1,30 +1,5 @@
-import os
 from yaml import dump
 
-possible_configurations = [
-    'tag',
-    'tag_is_lowercase',
-    'tag_is_uppercase',
-    'tag_is_capitalized',
-    'convention',
-]
-
-# refactor this function, surely there is a better way of writing this
-def run_config(array, tag, tag_is_capitalized, tag_is_lowercase, tag_is_uppercase,convention):
-    for conf in possible_configurations:
-        if conf in array:
-            if conf == 'tag':
-                tag = str(array[conf])
-            elif conf == 'tag_is_lowercase':
-                tag_is_lowercase = bool(array[conf])
-            elif conf == 'tag_is_uppercase':
-                tag_is_uppercase = bool(array[conf])
-            elif conf == 'tag_is_capitalized':
-                tag_is_capitalized = bool(array[conf])
-            elif conf == 'convention':
-                convention = str(array[conf])
-    return tag, tag_is_capitalized, tag_is_lowercase, tag_is_uppercase, convention
-
 def get_text(context=False):
     if context:
         tag = str(input("type the tag: "))
@@ -36,29 +11,6 @@ def get_text(context=False):
         msg = str(input("type the commit message: ")).lower()
         return tag, msg
 
-def angular_convention():
-    tag, msg, context = get_text(context=True)
-    tag = tag.lower()
-    os.system("git commit -m '%s(%s): %s'" % (tag, context, msg))
-
-def changelog_convention():
-    tag, msg = get_text()
-    tag = tag.upper()
-    os.system("git commit -m '%s: %s'" % (tag, msg))
-
-def symphony_convention():
-    tag, msg = get_text()
-    tag = tag.capitalize()
-    os.system("git commit -m '[%s] %s'" % (tag, msg))
-
-def just_message():
-    msg = str(input("commit message: "))
-    os.system("git commit -m '%s'" % msg.capitalize())
-
-# FUTURE: implement
-def custom_convention():
-    pass
-
 def create_file(convention_name):
     data = dict(
         convention = convention_name