chore(core): pass linting (a lot looser than other since core is supposed to be a bit flexible)

Author: nartc

libs/core/.eslintrc.json

@@ -6,16 +6,32 @@
 			"files": ["*.ts"],
 			"extends": ["plugin:@nx/angular", "plugin:@angular-eslint/template/process-inline-templates"],
 			"rules": {
-				"@angular-eslint/directive-selector": 0,
-				"@angular-eslint/component-selector": 0,
-				"@angular-eslint/component-class-suffix": 0,
-				"@angular-eslint/directive-class-suffix": 0,
-				"@angular-eslint/no-host-metadata-property": 0,
-				"@angular-eslint/no-input-rename": 0,
-				"@typescript-eslint/no-explicit-any": 0,
-				"@typescript-eslint/no-empty-function": 0
+				"@angular-eslint/directive-selector": "off",
+				"@angular-eslint/component-selector": "off",
+				"@angular-eslint/component-class-suffix": "off",
+				"@angular-eslint/directive-class-suffix": "off",
+				"@angular-eslint/no-host-metadata-property": "off",
+				"@angular-eslint/no-input-rename": "off",
+				"@typescript-eslint/no-explicit-any": "off",
+				"@typescript-eslint/no-empty-function": "off",
+        "@typescript-eslint/no-non-null-assertion": "off",
+        "@typescript-eslint/ban-types": "off",
+        "@typescript-eslint/no-empty-interface": "off",
+        "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }]
 			}
 		},
+    {
+      "files": ["*.spec.ts"],
+      "rules": {
+        "@nx/enforce-module-boundaries": "off"
+      }
+    },
+    {
+      "files": ["web-gl-rendering-context.ts"],
+      "rules": {
+        "@typescript-eslint/ban-ts-comment": "off"
+      }
+    },
 		{
 			"files": ["*.html"],
 			"extends": ["plugin:@nx/angular-template"],
@@ -25,7 +41,22 @@
 			"files": ["*.json"],
 			"parser": "jsonc-eslint-parser",
 			"rules": {
-				"@nx/dependency-checks": "error"
+				"@nx/dependency-checks": [
+					"error",
+					{
+						"ignoredDependencies": [
+							"@analogjs/vite-plugin-angular",
+							"@angular/router",
+							"@nx/devkit",
+							"@nx/vite",
+							"@phenomnomnominal/tsquery",
+							"nx",
+							"rxjs",
+							"tslib",
+							"vite"
+						]
+					}
+				]
 			}
 		}
 	]

libs/core/src/lib/loop.ts

@@ -147,7 +147,7 @@ function createLoop<TCanvas>(roots: Map<TCanvas, NgtSignalStore<NgtState>>) {
 
 	function advance(
 		timestamp: number,
-		runGlobalEffects: boolean = true,
+		runGlobalEffects = true,
 		store?: NgtSignalStore<NgtState>,
 		frame?: XRFrame,
 	): void {

libs/core/src/lib/renderer/index.ts

@@ -128,7 +128,7 @@ export class NgtRenderer implements Renderer2 {
 		if (name === SPECIAL_DOM_TAG.NGT_PRIMITIVE) {
 			if (!injectedArgs[0]) throw new Error(`[NGT] ngt-primitive without args is invalid`);
 			const object = injectedArgs[0];
-			let localState = getLocalState(object);
+			const localState = getLocalState(object);
 			if (!localState) {
 				// NOTE: if an object isn't already "prepared", we prepare it
 				prepare(object, { store: this.rootStore, primitive: true });
@@ -328,7 +328,7 @@ export class NgtRenderer implements Renderer2 {
 		el: NgtRendererNode,
 		name: string,
 		value: string,
-		namespace?: string | null | undefined,
+		_namespace?: string | null | undefined,
 	): boolean {
 		const rS = el.__ngt_renderer__;
 		if (rS[NgtRendererClassId.destroyed]) return false;

libs/core/src/lib/renderer/utils.ts

@@ -47,7 +47,6 @@ export function attachThreeChild(parent: NgtInstanceNode, child: NgtInstanceNode
 
 	// whether the child is added to the parent with parent.add()
 	let added = false;
-	let attached = false;
 
 	// assign store on child if not already exist
 	// or child store is not the same as parent store

libs/core/src/lib/roots.ts

@@ -56,17 +56,19 @@ export function injectCanvasRootInitializer(injector?: Injector) {
 					const root = roots.get(canvas);
 					if (root) {
 						root.update((state) => ({ internal: { ...state.internal, active: false } }));
-						try {
-							const state = root.get();
-							state.events.disconnect?.();
-							state.gl?.renderLists?.dispose?.();
-							state.gl?.forceContextLoss?.();
-							if (state.gl?.xr) state.xr.disconnect();
-							dispose(state);
-							roots.delete(canvas);
-						} catch (e) {
-							console.error('[NGT] Unexpected error while destroying Canvas Root', e);
-						}
+						setTimeout(() => {
+							try {
+								const state = root.get();
+								state.events.disconnect?.();
+								state.gl?.renderLists?.dispose?.();
+								state.gl?.forceContextLoss?.();
+								if (state.gl?.xr) state.xr.disconnect();
+								dispose(state);
+								roots.delete(canvas);
+							} catch (e) {
+								console.error('[NGT] Unexpected error while destroying Canvas Root', e);
+							}
+						}, timeout);
 					}
 				},
 				configure: (inputs: NgtCanvasOptions) => {
@@ -235,8 +237,8 @@ export function injectCanvasRootInitializer(injector?: Injector) {
 					// Avoid accessing ColorManagement to play nice with older versions
 					if (ColorManagement) {
 						const colorManagement = ColorManagement as NgtAnyRecord;
-						if ('enabled' in colorManagement) colorManagement['enabled'] = !legacy ?? false;
-						else if ('legacyMode' in colorManagement) colorManagement['legacyMode'] = legacy ?? true;
+						if ('enabled' in colorManagement) colorManagement['enabled'] = !legacy;
+						else if ('legacyMode' in colorManagement) colorManagement['legacyMode'] = legacy;
 					}
 
 					if (!isConfigured) {

libs/core/src/lib/utils/attach.ts

@@ -16,12 +16,7 @@ export function attach(object: NgtAnyRecord, value: unknown, paths: string[] = [
 	}
 }
 
-export function detach(
-	parent: NgtAnyRecord,
-	child: NgtAnyRecord,
-	attachProp: string[] | NgtAttachFunction,
-	useApplyProps = false,
-) {
+export function detach(parent: NgtAnyRecord, child: NgtAnyRecord, attachProp: string[] | NgtAttachFunction) {
 	const childLocalState = getLocalState(child);
 	if (childLocalState) {
 		if (Array.isArray(attachProp)) attach(parent, childLocalState.previousAttach, attachProp, childLocalState.isRaw);

libs/core/testing/src/lib/utils/mock-canvas.ts

@@ -28,18 +28,22 @@ export function createMockCanvas({
 
 	if (globalThis.HTMLCanvasElement) {
 		const getContext = HTMLCanvasElement.prototype.getContext;
-		HTMLCanvasElement.prototype.getContext = function (this: HTMLCanvasElement, id: string) {
+		HTMLCanvasElement.prototype.getContext = function (
+			this: HTMLCanvasElement,
+			...args: Parameters<typeof getContext>
+		) {
+			const id = args[0];
 			if (id.startsWith('webgl')) return new WebGL2RenderingContext(this);
-			return getContext.apply(this, arguments as any);
+			return getContext.apply(this, args);
 		} as any;
 	}
 
 	beforeReturn?.(canvas);
 
 	class WebGLRenderingContext extends WebGL2RenderingContext {}
-	// @ts-expect-error
+	// @ts-expect-error - WebGLRenderingContext is not defined in the global scope for non-browser
 	globalThis.WebGLRenderingContext ??= WebGLRenderingContext;
-	// @ts-expect-error
+	// @ts-expect-error - WebGL2RenderingContext is not defined in the global scope for non-browser
 	globalThis.WebGL2RenderingContext ??= WebGL2RenderingContext;
 
 	return canvas;