fix(core): assign intermediate ref to the parent store for non-three instance during applyProps

For default objects like the default `MeshBasicMaterial` on a
`ngt-mesh`, we want to still have access to the color space information
on the renderer which is only available on `NgtStore`. In order to do
this, we assign an intermediate reference to the store from the `parent`
during `applyProps` so the instance (`MeshBasicMaterial` in this
example) has access to the Store.

<ngt-mesh>
  <ngt-value [rawValue]="texture()" attach="material.map" />
</ngt-mesh>

things like this. Consumers probably do not run into this because they
would use `ngt-mesh-basic-material#map` instead.

Author: nartc

libs/core/src/lib/utils/apply-props.ts

@@ -25,14 +25,18 @@ function diffProps(instance: NgtAnyRecord, props: NgtAnyRecord) {
 	return changes;
 }
 
+// NOTE: this is a workaround to give the instance a change to have the store from the parent.
+//  we clear this property after the applyProps is done
+export const NGT_APPLY_PROPS = '__ngt_apply_props__';
+
 // This function applies a set of changes to the instance
 export function applyProps(instance: NgtInstanceNode, props: NgtAnyRecord) {
 	// if props is empty
 	if (!Object.keys(props).length) return instance;
 
 	// filter equals, and reserved props
 	const localState = getLocalState(instance);
-	const rootState = localState?.store?.snapshot ?? ({} as NgtState);
+	const rootState = localState?.store?.snapshot ?? instance[NGT_APPLY_PROPS]?.snapshot ?? ({} as NgtState);
 	const changes = diffProps(instance, props);
 
 	for (let i = 0; i < changes.length; i++) {
@@ -125,5 +129,10 @@ export function applyProps(instance: NgtInstanceNode, props: NgtAnyRecord) {
 		localState.onUpdate(instance);
 	}
 
+	// clearing the intermediate store from the instance
+	if (instance[NGT_APPLY_PROPS]) {
+		delete instance[NGT_APPLY_PROPS];
+	}
+
 	return instance;
 }

libs/core/src/lib/utils/attach.ts

@@ -1,6 +1,6 @@
 import { getLocalState } from '../instance';
 import { NgtAnyRecord, NgtAttachFunction, NgtState } from '../types';
-import { applyProps } from './apply-props';
+import { applyProps, NGT_APPLY_PROPS } from './apply-props';
 import { NgtSignalStore } from './signal-store';
 
 export function attach(object: NgtAnyRecord, value: unknown, paths: string[] = [], useApplyProps = false): void {
@@ -11,7 +11,7 @@ export function attach(object: NgtAnyRecord, value: unknown, paths: string[] = [
 		if (useApplyProps) applyProps(object, { [base]: value });
 		else object[base] = value;
 	} else {
-		assignEmpty(object, base);
+		assignEmpty(object, base, useApplyProps);
 		attach(object[base], value, remaining, useApplyProps);
 	}
 }
@@ -24,10 +24,22 @@ export function detach(parent: NgtAnyRecord, child: NgtAnyRecord, attachProp: st
 	}
 }
 
-function assignEmpty(obj: NgtAnyRecord, base: string) {
+function assignEmpty(obj: NgtAnyRecord, base: string, shouldAssignStoreForApplyProps = false) {
 	if ((!Object.hasOwn(obj, base) && Reflect && !!Reflect.has && !Reflect.has(obj, base)) || obj[base] === undefined) {
 		obj[base] = {};
 	}
+
+	if (shouldAssignStoreForApplyProps) {
+		const localState = getLocalState(obj[base]);
+		// if we already have local state, bail out
+		if (localState) return;
+
+		const parentLocalState = getLocalState(obj);
+		// if parent doesn't have local state, bail out
+		if (!parentLocalState) return;
+
+		Object.assign(obj[base], { [NGT_APPLY_PROPS]: parentLocalState.store });
+	}
 }
 
 export function createAttachFunction<TChild = any, TParent = any>(