feat: confirm rawValue to work as attribute binding

nartc · nartc · commit b13367073a2d · 2023-01-25T14:04:21.000-06:00
diff --git a/apps/demo/src/app/cubes/cubes.component.ts b/apps/demo/src/app/cubes/cubes.component.ts
@@ -41,7 +41,9 @@ export class Cube {
     template: `
         <ngt-color *args="['#BFD1E5']" attach="background" />
 
-        <ngt-ambient-light [intensity]="0.5" />
+        <ngt-ambient-light>
+            <ngt-value rawValue="0.5" attach="intensity" />
+        </ngt-ambient-light>
         <ngt-spot-light [intensity]="0.5" [position]="10" [angle]="0.15" [penumbra]="1" />
         <ngt-point-light [intensity]="0.5" [position]="-10" />
 
diff --git a/libs/angular-three/src/lib/renderer/state.ts b/libs/angular-three/src/lib/renderer/state.ts
@@ -186,8 +186,6 @@ export class NgtRendererStore {
         }
 
         if (name === SPECIAL_PROPERTIES.VALUE) {
-            // TODO  the last time we tried this here, this didn't work
-
             // coercion
             let maybeCoerced: any = value;
             if (maybeCoerced === '' || maybeCoerced === 'true' || maybeCoerced === 'false') {

Original file line number	Diff line number	Diff line change
`@@ -186,8 +186,6 @@ export class NgtRendererStore {`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`if (name === SPECIAL_PROPERTIES.VALUE) {`
`189`		`- // TODO the last time we tried this here, this didn't work`
`190`		`-`
`191`	`189`	`// coercion`
`192`	`190`	`let maybeCoerced: any = value;`
`193`	`191`	`if (maybeCoerced === '' \|\| maybeCoerced === 'true' \|\| maybeCoerced === 'false') {`