fix(@angular/build): ensure chokidar watcher is ready before returning

When initializing chokidar.watch with ignoreInitial: true, files visited during the initial scan are treated as the initial baseline and do not emit change events. If createChokidarWatcher returns before the initial scan completes, subsequent file modifications made shortly after setup can be visited for the first time during the initial scan, causing the change event to be dropped.

Awaiting the ready event ensures the watcher's initial scan is completed and the watcher is actively listening before returning. This resolves test flakiness in rebuild error detection tests where files are modified immediately after the initial build.

Author: alan-agius4

packages/angular/build/src/builders/dev-server/tests/behavior/build-errors_spec.ts

@@ -38,8 +38,8 @@ describeServeBuilder(executeDevServer, DEV_SERVER_BUILDER_INFO, (harness, setupT
             expectNoLog(logs, 'Unexpected character "EOF"');
           },
         ],
-        { outputLogsOnFailure: false, timeout: 90_000 },
+        { outputLogsOnFailure: false },
       );
-    }, 120_000);
+    });
   });
 });

packages/angular/build/src/tools/esbuild/watcher.ts

@@ -663,6 +663,16 @@ async function createChokidarWatcher(
     usePolling: !!options?.polling,
     interval: options?.interval,
   });
+
+  // Wait for the watcher to complete its initial filesystem scan before returning.
+  // With `ignoreInitial: true`, any file visited during the initial scan is treated as the initial baseline
+  // and will not emit 'add' or 'change' events. Awaiting 'ready' ensures that rapid file modifications
+  // made right after watcher setup (e.g. in rebuild tests) are not swallowed as initial files.
+  await new Promise<void>((resolve, reject) => {
+    watcher.once('ready', resolve);
+    watcher.once('error', reject);
+  });
+
   const initTime = Date.now();
 
   const handleEvent = (type: 'added' | 'modified' | 'removed', rawPath: string) => {