Revert "refactor(@angular/cli): import markdown files directly for command descriptions"

This reverts commit 3d7f081.

Author: alan-agius4

packages/angular/cli/src/command-builder/command-module.ts

@@ -7,6 +7,8 @@
  */
 
 import { schema } from '@angular-devkit/core';
+import { readFileSync } from 'node:fs';
+import { join, posix, relative } from 'node:path';
 import type { ArgumentsCamelCase, Argv, CommandModule as YargsCommandModule } from 'yargs';
 import { Parser as yargsParser } from 'yargs/helpers';
 import { getAnalyticsUserId } from '../analytics/analytics';
@@ -18,7 +20,6 @@ import { AngularWorkspace } from '../utilities/config';
 import { memoize } from '../utilities/memoize';
 import { CommandContext, CommandScope, Options, OtherOptions } from './definitions';
 import { Option, addSchemaOptionsToCommand } from './utilities/json-schema';
-import '../utilities/markdown-loader';
 
 export { CommandScope };
 export type { CommandContext, Options, OtherOptions };
@@ -30,11 +31,8 @@ export interface CommandModuleImplementation<T extends {} = {}> extends Omit<
   /** Scope in which the command can be executed in. */
   scope: CommandScope;
 
-  /** Long description for the command in JSON help text. */
-  longDescription?: string;
-
-  /** Relative path to the long description file for the command in JSON help text. */
-  longDescriptionRelativePath?: string;
+  /** Path used to load the long description for the command in JSON help text. */
+  longDescriptionPath?: string;
 
   /** Object declaring the options the command accepts, or a function accepting and returning a yargs instance. */
   builder(argv: Argv): Promise<Argv<T>> | Argv<T>;
@@ -52,8 +50,7 @@ export interface FullDescribe {
 export abstract class CommandModule<T extends {} = {}> implements CommandModuleImplementation<T> {
   abstract readonly command: string;
   abstract readonly describe: string | false;
-  readonly longDescription?: string;
-  readonly longDescriptionRelativePath?: string;
+  abstract readonly longDescriptionPath?: string;
   protected readonly shouldReportAnalytics: boolean = true;
   readonly scope: CommandScope = CommandScope.Both;
 
@@ -71,22 +68,23 @@ export abstract class CommandModule<T extends {} = {}> implements CommandModuleI
    * `false` will result in a hidden command.
    */
   public get fullDescribe(): FullDescribe | false {
-    if (this.describe === false) {
-      return false;
-    }
-
-    const description: FullDescribe = {
-      describe: this.describe,
-    };
-
-    if (this.longDescription) {
-      description.longDescription = this.longDescription.replace(/\r\n/g, '\n');
-      description.longDescriptionRelativePath =
-        this.longDescriptionRelativePath ??
-        `@angular/cli/src/commands/${this.commandName}/long-description.md`;
-    }
-
-    return description;
+    return this.describe === false
+      ? false
+      : {
+          describe: this.describe,
+          ...(this.longDescriptionPath
+            ? {
+                longDescriptionRelativePath: relative(
+                  join(__dirname, '../../../../'),
+                  this.longDescriptionPath,
+                ).replace(/\\/g, posix.sep),
+                longDescription: readFileSync(this.longDescriptionPath, 'utf8').replace(
+                  /\r\n/g,
+                  '\n',
+                ),
+              }
+            : {}),
+        };
   }
 
   protected get commandName(): string {

packages/angular/cli/src/commands/add/cli.ts

@@ -29,9 +29,6 @@ import { NgAddSaveDependency, PackageManifest, PackageMetadata } from '../../pac
 import { assertIsError } from '../../utilities/error';
 import { isTTY } from '../../utilities/tty';
 import { VERSION } from '../../utilities/version';
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
-import longDescription from './long-description.md';
 
 class CommandError extends Error {}
 
@@ -103,7 +100,7 @@ export default class AddCommandModule
 {
   command = 'add <collection>';
   describe = 'Adds support for an external library to your project.';
-  override longDescription = longDescription;
+  longDescriptionPath = join(__dirname, 'long-description.md');
   protected override allowPrivateSchematics = true;
   private readonly schematicName = 'ng-add';
   private rootRequire = createRequire(this.context.root + '/');

packages/angular/cli/src/commands/analytics/cli.ts

@@ -6,6 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
+import { join } from 'node:path';
 import { Argv } from 'yargs';
 import {
   CommandModule,
@@ -17,9 +18,6 @@ import {
   demandCommandFailureMessage,
 } from '../../command-builder/utilities/command';
 import { AnalyticsInfoCommandModule } from './info/cli';
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
-import longDescription from './long-description.md';
 import {
   AnalyticsDisableModule,
   AnalyticsEnableModule,
@@ -32,7 +30,7 @@ export default class AnalyticsCommandModule
 {
   command = 'analytics';
   describe = 'Configures the gathering of Angular CLI usage metrics.';
-  override longDescription = longDescription;
+  longDescriptionPath = join(__dirname, 'long-description.md');
 
   builder(localYargs: Argv): Argv {
     const subcommands = [

packages/angular/cli/src/commands/analytics/info/cli.ts

@@ -20,6 +20,7 @@ export class AnalyticsInfoCommandModule
 {
   command = 'info';
   describe = 'Prints analytics gathering and reporting configuration in the console.';
+  longDescriptionPath?: string;
 
   builder(localYargs: Argv): Argv {
     return localYargs.strict();

packages/angular/cli/src/commands/analytics/settings/cli.ts

@@ -26,6 +26,8 @@ abstract class AnalyticsSettingModule
   extends CommandModule<AnalyticsCommandArgs>
   implements CommandModuleImplementation<AnalyticsCommandArgs>
 {
+  longDescriptionPath?: string;
+
   builder(localYargs: Argv): Argv<AnalyticsCommandArgs> {
     return localYargs
       .option('global', {

packages/angular/cli/src/commands/build/cli.ts

@@ -6,12 +6,10 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
+import { join } from 'node:path';
 import { ArchitectCommandModule } from '../../command-builder/architect-command-module';
 import { CommandModuleImplementation } from '../../command-builder/command-module';
 import { RootCommands } from '../command-config';
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
-import longDescription from './long-description.md';
 
 export default class BuildCommandModule
   extends ArchitectCommandModule
@@ -22,5 +20,5 @@ export default class BuildCommandModule
   aliases = RootCommands['build'].aliases;
   describe =
     'Compiles an Angular application or library into an output directory named dist/ at the given output path.';
-  override longDescription = longDescription;
+  longDescriptionPath = join(__dirname, 'long-description.md');
 }

packages/angular/cli/src/commands/cache/clean/cli.ts

@@ -18,6 +18,7 @@ import { getCacheConfig } from '../utilities';
 export class CacheCleanModule extends CommandModule implements CommandModuleImplementation {
   command = 'clean';
   describe = 'Deletes persistent disk cache from disk.';
+  longDescriptionPath: string | undefined;
   override scope = CommandScope.In;
 
   builder(localYargs: Argv): Argv {

packages/angular/cli/src/commands/cache/cli.ts

@@ -6,6 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
+import { join } from 'node:path';
 import { Argv } from 'yargs';
 import {
   CommandModule,
@@ -19,9 +20,6 @@ import {
 } from '../../command-builder/utilities/command';
 import { CacheCleanModule } from './clean/cli';
 import { CacheInfoCommandModule } from './info/cli';
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore strict-deps: Markdown files are asset dependencies bundled/loaded at runtime
-import longDescription from './long-description.md';
 import { CacheDisableModule, CacheEnableModule } from './settings/cli';
 
 export default class CacheCommandModule
@@ -30,7 +28,7 @@ export default class CacheCommandModule
 {
   command = 'cache';
   describe = 'Configure persistent disk cache and retrieve cache statistics.';
-  override longDescription = longDescription;
+  longDescriptionPath = join(__dirname, 'long-description.md');
   override scope = CommandScope.In;
 
   builder(localYargs: Argv): Argv {

packages/angular/cli/src/commands/cache/info/cli.ts

@@ -21,6 +21,7 @@ import { getCacheConfig } from '../utilities';
 export class CacheInfoCommandModule extends CommandModule implements CommandModuleImplementation {
   command = 'info';
   describe = 'Prints persistent disk cache configuration and statistics in the console.';
+  longDescriptionPath?: string | undefined;
   override scope = CommandScope.In;
 
   builder(localYargs: Argv): Argv {

packages/angular/cli/src/commands/cache/settings/cli.ts

@@ -18,6 +18,7 @@ export class CacheDisableModule extends CommandModule implements CommandModuleIm
   command = 'disable';
   aliases = 'off';
   describe = 'Disables persistent disk cache for all projects in the workspace.';
+  longDescriptionPath: string | undefined;
   override scope = CommandScope.In;
 
   builder(localYargs: Argv): Argv {
@@ -33,6 +34,7 @@ export class CacheEnableModule extends CommandModule implements CommandModuleImp
   command = 'enable';
   aliases = 'on';
   describe = 'Enables disk cache for all projects in the workspace.';
+  longDescriptionPath: string | undefined;
   override scope = CommandScope.In;
 
   builder(localYargs: Argv): Argv {