fix(@angular/build): only compile included test files in unit-test builder

When running the `unit-test` builder with `--include`, TypeScript compilation previously compiled all test files matched by the tsconfig file, causing compilation errors in unrelated test files to fail the test run.

This change introduces an `excludeFiles` option that excludes test files not matched by the include patterns from the TypeScript program's root files, while preserving ambient declarations and application source files.

Fixes #34089

Author: alan-agius4

packages/angular/build/src/builders/application/options.ts

@@ -138,6 +138,11 @@ interface InternalOptions {
    * there. Used exclusively for tests and shouldn't be used for other kinds of builds.
    */
   disableCodeSplitting?: boolean;
+
+  /**
+   * An array of files to exclude from the TypeScript compilation root names.
+   */
+  excludeFiles?: string[];
 }
 
 /** Full set of options for `application` builder. */
@@ -447,6 +452,7 @@ export async function normalizeOptions(
     verbose,
     watch,
     progress = true,
+    excludeFiles,
     externalPackages,
     namedChunks,
     budgets,
@@ -494,6 +500,7 @@ export async function normalizeOptions(
     workspaceRoot,
     entryPoints,
     disableCodeSplitting,
+    excludeFiles: excludeFiles?.map((file: string) => path.resolve(workspaceRoot, file)),
     optimizationOptions,
     outputOptions,
     outExtension,

packages/angular/build/src/builders/unit-test/options.ts

@@ -120,6 +120,7 @@ export async function normalizeOptions(
     // Target/configuration specified options
     buildTarget,
     include: options.include ?? ['**/*.spec.ts'],
+    hasExplicitInclude: options.include !== undefined,
     exclude: options.exclude,
     filter,
     runnerName: runner ?? Runner.Vitest,

packages/angular/build/src/builders/unit-test/runners/vitest/build-options.ts

@@ -17,7 +17,7 @@ import { createProjectResolver } from '../../../../utils/resolve-project';
 import type { ApplicationBuilderInternalOptions } from '../../../application/options';
 import { OutputHashing } from '../../../application/schema';
 import { NormalizedUnitTestBuilderOptions } from '../../options';
-import { findTests, getTestEntrypoints } from '../../test-discovery';
+import { TEST_FILE_INFIXES, findTests, getTestEntrypoints } from '../../test-discovery';
 import { RunnerOptions } from '../api';
 
 /**
@@ -198,7 +198,15 @@ export async function getVitestBuildOptions(
   options: NormalizedUnitTestBuilderOptions,
   baseBuildOptions: Partial<ApplicationBuilderInternalOptions>,
 ): Promise<RunnerOptions> {
-  const { workspaceRoot, projectSourceRoot, include, exclude = [], watch, providersFile } = options;
+  const {
+    workspaceRoot,
+    projectSourceRoot,
+    include,
+    exclude = [],
+    watch,
+    providersFile,
+    setupFiles,
+  } = options;
 
   // Find test files
   const testFiles = await findTests(include, exclude, workspaceRoot, projectSourceRoot);
@@ -217,8 +225,20 @@ export async function getVitestBuildOptions(
     removeTestExtension: true,
   });
 
-  if (options.setupFiles?.length) {
-    const setupEntryPoints = getTestEntrypoints(options.setupFiles, {
+  let excludeFiles: string[] | undefined;
+  if (options.hasExplicitInclude) {
+    const allTestFiles = await findTests(
+      TEST_FILE_INFIXES.map((infix) => `**/*${infix}.@(ts|tsx)`),
+      exclude,
+      workspaceRoot,
+      projectSourceRoot,
+    );
+    const testFilesSet = new Set(testFiles);
+    excludeFiles = allTestFiles.filter((file) => !testFilesSet.has(file));
+  }
+
+  if (setupFiles?.length) {
+    const setupEntryPoints = getTestEntrypoints(setupFiles, {
       projectSourceRoot,
       workspaceRoot,
       removeTestExtension: false,
@@ -258,6 +278,7 @@ export async function getVitestBuildOptions(
     optimization: false,
     namedChunks: false,
     entryPoints,
+    excludeFiles,
     // Vitest's Node-based module loading emulation (vite-node) is not fully spec compliant and lacks
     // live ESM bindings across chunk boundaries. This can cause uninitialized exports or break mocking.
     // Disabling code splitting avoids shared chunks, but increases build and coverage memory/time.

packages/angular/build/src/builders/unit-test/test-discovery.ts

@@ -17,7 +17,7 @@ import { toPosixPath } from '../../utils/path';
  * An array of file infix notations that identify a file as a test file.
  * For example, `.spec` in `app.component.spec.ts`.
  */
-const TEST_FILE_INFIXES = ['.spec', '.test'];
+export const TEST_FILE_INFIXES = ['.spec', '.test'];
 
 /** Maximum length for a generated test entrypoint name. */
 const MAX_FILENAME_LENGTH = 128;

packages/angular/build/src/builders/unit-test/tests/options/include_spec.ts

@@ -83,5 +83,32 @@ describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {
         expect(result?.success).toBeTrue();
       });
     });
+
+    it('should ignore TypeScript compilation errors in non-included test files', async () => {
+      await harness.writeFiles({
+        'src/app/services/test.service.spec.ts': `
+          describe('TestService', () => {
+            it('should succeed', () => {
+              expect(true).toBe(true);
+            });
+          });`,
+        'src/app/broken.service.spec.ts': `
+          // This test has a TypeScript type error that would fail compilation if compiled
+          const invalidNumber: number = 'not a number';
+          describe('BrokenService', () => {
+            it('should fail compilation', () => {
+              expect(invalidNumber).toBe(1);
+            });
+          });`,
+      });
+
+      harness.useTarget('test', {
+        ...BASE_OPTIONS,
+        include: ['src/app/services/test.service.spec.ts'],
+      });
+
+      const { result } = await harness.executeOnce();
+      expect(result?.success).toBeTrue();
+    });
   });
 });

packages/angular/build/src/tools/angular/compilation/compiler-options.ts

@@ -20,6 +20,7 @@ export interface CompilerOptionOverrides {
   instrumentForCoverage?: boolean;
   includeTestMetadata?: boolean;
   customConditions?: string[];
+  excludeFiles?: string[];
 }
 
 export function transformCompilerOptions(

packages/angular/build/src/tools/angular/compilation/typescript-compilation.ts

@@ -9,7 +9,7 @@
 import type * as ng from '@angular/compiler-cli';
 import type { PartialMessage } from 'esbuild';
 import ts from 'typescript';
-import { toPosixPath } from '../../../utils/path';
+import { canonicalizePath, toPosixPath } from '../../../utils/path';
 import { profileAsync, profileSync } from '../../../utils/profiling';
 import { AngularCompilation, DiagnosticModes } from './angular-compilation';
 import { type CompilerOptionOverrides, transformCompilerOptions } from './compiler-options';
@@ -39,7 +39,7 @@ export abstract class TypeScriptCompilation extends AngularCompilation {
 
     const {
       options: originalCompilerOptions,
-      rootNames,
+      rootNames: originalRootNames,
       errors,
     } = profileSync('NG_READ_CONFIG', () =>
       readConfiguration(tsconfig, {
@@ -60,6 +60,18 @@ export abstract class TypeScriptCompilation extends AngularCompilation {
       }),
     );
 
+    let rootNames = originalRootNames;
+    if (compilerOptionOverrides?.excludeFiles?.length) {
+      const excludeFilesSet = new Set(
+        compilerOptionOverrides.excludeFiles.map((file) => canonicalizePath(toPosixPath(file))),
+      );
+      rootNames = originalRootNames.filter((file) => {
+        const normalizedFile = canonicalizePath(toPosixPath(file));
+
+        return !excludeFilesSet.has(normalizedFile);
+      });
+    }
+
     const { compilerOptions, warnings } = transformCompilerOptions(
       ts,
       originalCompilerOptions,

packages/angular/build/src/tools/esbuild/angular/compiler-plugin.ts

@@ -61,6 +61,7 @@ export interface CompilerPluginOptions {
   externalRuntimeStyles?: boolean;
   instrumentForCoverage?: (request: string) => boolean;
   templateUpdates?: Map<string, string>;
+  excludeFiles?: string[];
 }
 
 // eslint-disable-next-line max-lines-per-function
@@ -329,17 +330,21 @@ export function createCompilerPlugin(
               instrumentForCoverage: !!pluginOptions.instrumentForCoverage,
               includeTestMetadata: !!pluginOptions.includeTestMetadata,
               customConditions: build.initialOptions.conditions,
+              excludeFiles: pluginOptions.excludeFiles,
             },
           );
+
           if (initializationResult.warnings?.length) {
             setupWarnings?.push(...initializationResult.warnings);
           }
+
           angularCompilationContext.setCompilerOptions(initializationResult.compilerOptions);
           shouldTsIgnoreJs = !initializationResult.compilerOptions.allowJs;
           useTypeScriptTranspilation =
             !!initializationResult.compilerOptions['_useTypeScriptTranspilation'];
           referencedFiles = initializationResult.referencedFiles;
           externalStylesheets = initializationResult.externalStylesheets;
+
           if (initializationResult.templateUpdates) {
             // Propagate any template updates
             initializationResult.templateUpdates.forEach((value, key) =>

packages/angular/build/src/tools/esbuild/compiler-plugin-options.ts

@@ -28,6 +28,7 @@ export function createCompilerPluginOptions(
     externalRuntimeStyles,
     instrumentForCoverage,
     optimizationOptions,
+    excludeFiles,
   } = options;
   const incremental = !!options.watch;
 
@@ -45,5 +46,6 @@ export function createCompilerPluginOptions(
     instrumentForCoverage,
     templateUpdates,
     includeTestMetadata: !optimizationOptions.scripts,
+    excludeFiles,
   };
 }