Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a syncTheme method in StickyHeaderController to synchronize the main table's theme to the sticky header instance (stickyS2). The review feedback points out that calling setThemeCfg triggers expensive internal computations that are immediately overwritten by the direct assignment of theme on the next line, and suggests directly assigning themeName and theme instead to avoid this overhead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Size Change: +39 B (+0.01%) Total Size: 745 kB 📦 View Changed
ℹ️ View Unchanged
|
|
🎉 This PR is included in version @antv/s2-v2.7.2-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot