Skip to content

fix: 表头吸顶主题同步#3351

Open
Alexzjt wants to merge 1 commit into
nextfrom
fix/3350
Open

fix: 表头吸顶主题同步#3351
Alexzjt wants to merge 1 commit into
nextfrom
fix/3350

Conversation

@Alexzjt

@Alexzjt Alexzjt commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

👀 PR includes

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After
iShot_2026-06-03_20 55 39 iShot_2026-06-03_20 43 24

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a syncTheme method in StickyHeaderController to synchronize the main table's theme to the sticky header instance (stickyS2). The review feedback points out that calling setThemeCfg triggers expensive internal computations that are immediately overwritten by the direct assignment of theme on the next line, and suggests directly assigning themeName and theme instead to avoid this overhead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/s2-core/src/ui/sticky-header/index.ts
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Size Change: +39 B (+0.01%)

Total Size: 745 kB

📦 View Changed
Filename Size Change
packages/s2-core/dist/s2.min.js 312 kB +39 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/s2-core/dist/s2-extends.min.js 209 kB
packages/s2-core/dist/s2.min.css 581 B
packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
packages/s2-react-components/dist/s2-react-components.min.js 123 kB
packages/s2-react/dist/s2-react.min.css 1.3 kB
packages/s2-react/dist/s2-react.min.js 38.5 kB
packages/s2-vue/dist/s2-vue.min.css 3.8 kB
packages/s2-vue/dist/s2-vue.min.js 54.2 kB

compressed-size-action

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version @antv/s2-v2.7.2-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛表格吸顶

1 participant