Commit d7b6a8f
committed
Address review: drop concurrency framing from compress() comment
The previous comment said the captured writerIndex() guarded against the
buffer being a 'shared reference to a vector's internal buffer'. As
@lidavidm pointed out, Arrow vectors are not safe for concurrent use,
so that framing implied a guarantee we do not provide.
Tighten the comment to state only the engineering invariant: the three
in-method consumers (empty-buffer check, size comparison, and the
uncompressed-length prefix) must all see the same value. Reference
GH-1116 for context.1 parent 4c754b1 commit d7b6a8f
1 file changed
Lines changed: 2 additions & 5 deletions
Lines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 32 | + | |
| 33 | + | |
37 | 34 | | |
38 | 35 | | |
39 | 36 | | |
| |||
0 commit comments