From 937f62c8fd5ed2f1a540acc6241c3e3ba4ed9017 Mon Sep 17 00:00:00 2001 From: Rok Mihevc Date: Mon, 7 Sep 2026 14:39:20 +0200 Subject: [PATCH] GH-48743: [C++] Re-enable timezone tests on Windows GCC Remove all six Windows GCC timezone test skips now that upstream has fixed libstdc++ bug 116110. Run the tests without version gates first so any remaining toolchain-specific failures can be identified by CI. Leave all test expectations, backend selection, and the Windows libc++ fallback unchanged. Signed-off-by: Rok Mihevc --- .../arrow/compute/kernels/scalar_cast_test.cc | 5 ---- .../compute/kernels/scalar_temporal_test.cc | 25 ------------------- 2 files changed, 30 deletions(-) diff --git a/cpp/src/arrow/compute/kernels/scalar_cast_test.cc b/cpp/src/arrow/compute/kernels/scalar_cast_test.cc index 364a4bd436b6..864ec4afce0c 100644 --- a/cpp/src/arrow/compute/kernels/scalar_cast_test.cc +++ b/cpp/src/arrow/compute/kernels/scalar_cast_test.cc @@ -2570,11 +2570,6 @@ TEST(Cast, TimestampToTime) { } TEST_F(CastTimezone, ZonedTimestampToTime) { - // TODO(GH-48743): GCC libstdc++ has a bug with DST transitions - // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110 -#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__) - GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743)."; -#endif CheckCast(ArrayFromJSON(timestamp(TimeUnit::NANO, "Pacific/Marquesas"), kTimestampJson), ArrayFromJSON(time64(TimeUnit::NANO), R"([ 52259123456789, 50003999999999, 56480001001001, 65000000000000, diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_test.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_test.cc index 1b9d9254c586..86a81ffdd384 100644 --- a/cpp/src/arrow/compute/kernels/scalar_temporal_test.cc +++ b/cpp/src/arrow/compute/kernels/scalar_temporal_test.cc @@ -708,11 +708,6 @@ TEST_F(ScalarTemporalTest, TestIsLeapYear) { } TEST_F(ScalarTemporalTest, TestZoned1) { - // TODO(GH-48743): GCC libstdc++ has a bug with DST transitions - // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110 -#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__) - GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743)."; -#endif std::vector timezones = {"Pacific/Marquesas", "-09:30"}; for (const auto& timezone : timezones) { auto unit = timestamp(TimeUnit::NANO, timezone); @@ -811,11 +806,6 @@ TEST_F(ScalarTemporalTest, TestZoned1) { } TEST_F(ScalarTemporalTest, TestZoned2) { - // TODO(GH-48743): GCC libstdc++ has a bug with DST transitions - // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110 -#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__) - GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743)."; -#endif for (auto u : TimeUnit::values()) { auto unit = timestamp(u, "Australia/Broken_Hill"); auto month = "[1, 3, 1, 5, 1, 12, 12, 12, 1, 1, 1, 1, 12, 12, 12, 1, null]"; @@ -2777,11 +2767,6 @@ TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, CeilUTC) { } TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, CeilZoned) { - // TODO(GH-48743): GCC libstdc++ has a bug with DST transitions - // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110 -#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__) - GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743)."; -#endif std::string op = "ceil_temporal"; // Data for tests below was generated via lubridate with the exception @@ -3172,11 +3157,6 @@ TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, FloorUTC) { } TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, FloorZoned) { - // TODO(GH-48743): GCC libstdc++ has a bug with DST transitions - // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110 -#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__) - GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743)."; -#endif std::string op = "floor_temporal"; // Data for tests below was generated via lubridate with the exception @@ -3610,11 +3590,6 @@ TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, RoundUTC) { } TEST_F(ScalarTemporalTestMultipleSinceGreaterUnit, RoundZoned) { - // TODO(GH-48743): GCC libstdc++ has a bug with DST transitions - // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110 -#if defined(_WIN32) && defined(__GNUC__) && !defined(__clang__) - GTEST_SKIP() << "Test triggers GCC libstdc++ bug (GH-48743)."; -#endif std::string op = "round_temporal"; // Data for tests below was generated via lubridate with the exception