From a5ac045271e446b87ce323df5ca02960670de8c0 Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Tue, 8 Sep 2026 11:18:41 +0100 Subject: [PATCH 1/3] Only assign unassigned issues and rephrase docs --- .github/workflows/comment_bot.yml | 4 +++- CONTRIBUTING.md | 2 +- docs/source/developers/bug_reports.rst | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/comment_bot.yml b/.github/workflows/comment_bot.yml index ceff6c41d21a..280c496964c4 100644 --- a/.github/workflows/comment_bot.yml +++ b/.github/workflows/comment_bot.yml @@ -61,7 +61,9 @@ jobs: name: "Assign issue" permissions: issues: write - if: github.event.comment.body == 'take' + if: | + github.event.comment.body == 'take' && + github.event.issue.assignee == null runs-on: ubuntu-latest steps: - uses: actions/github-script@v9 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f23c18f326b0..2bb7669638bf 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,7 +25,7 @@ The Arrow project uses GitHub as a bug tracker. To report a bug, sign in to your GitHub account, navigate to [GitHub issues](https://github.com/apache/arrow/issues) and click on **New issue** . -To be assigned to an issue, add a comment "take" to that issue. +To be assigned to an unassigned issue, add a comment "take" to that issue. Before you create a new bug entry, we recommend you first search among existing Arrow issues in diff --git a/docs/source/developers/bug_reports.rst b/docs/source/developers/bug_reports.rst index 307261617acc..e1c8e769ba8e 100644 --- a/docs/source/developers/bug_reports.rst +++ b/docs/source/developers/bug_reports.rst @@ -243,5 +243,5 @@ Issue assignment ++++++++++++++++ Assignment signals commitment to work on an issue, and contributors should -self-assign issues when that work starts. Anyone can now self-assign issues -by commenting ``take``. +self-assign issues when that work starts. Anyone can self-assign an +unassigned issue by commenting ``take``. From 3d03aab941b51cfc975177363b1155a32635ca7c Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Tue, 8 Sep 2026 11:27:02 +0100 Subject: [PATCH 2/3] Update conditions for comment bot workflow Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- .github/workflows/comment_bot.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/comment_bot.yml b/.github/workflows/comment_bot.yml index 280c496964c4..8816ba7d078d 100644 --- a/.github/workflows/comment_bot.yml +++ b/.github/workflows/comment_bot.yml @@ -63,6 +63,7 @@ jobs: issues: write if: | github.event.comment.body == 'take' && + github.event.issue.pull_request == null && github.event.issue.assignee == null runs-on: ubuntu-latest steps: From e38264fb920119fd024a913735070ebfdbde08ac Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Thu, 17 Sep 2026 12:21:30 -0500 Subject: [PATCH 3/3] Remove "take" command --- .github/workflows/comment_bot.yml | 21 ------------------- CONTRIBUTING.md | 3 ++- docs/source/developers/bug_reports.rst | 6 ++++-- .../guide/step_by_step/finding_issues.rst | 4 ++-- .../guide/tutorials/python_tutorial.rst | 7 ++++--- docs/source/developers/reviewing.rst | 2 ++ 6 files changed, 14 insertions(+), 29 deletions(-) diff --git a/.github/workflows/comment_bot.yml b/.github/workflows/comment_bot.yml index 8816ba7d078d..044c761aa636 100644 --- a/.github/workflows/comment_bot.yml +++ b/.github/workflows/comment_bot.yml @@ -56,24 +56,3 @@ jobs: archery --debug trigger-bot \ --event-name "${GITHUB_EVENT_NAME}" \ --event-payload "${GITHUB_EVENT_PATH}" - - issue_assign: - name: "Assign issue" - permissions: - issues: write - if: | - github.event.comment.body == 'take' && - github.event.issue.pull_request == null && - github.event.issue.assignee == null - runs-on: ubuntu-latest - steps: - - uses: actions/github-script@v9 - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - script: | - github.rest.issues.addAssignees({ - owner: context.repo.owner, - repo: context.repo.repo, - issue_number: context.payload.issue.number, - assignees: context.payload.comment.user.login - }); diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2bb7669638bf..d9a06e884d22 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,7 +25,8 @@ The Arrow project uses GitHub as a bug tracker. To report a bug, sign in to your GitHub account, navigate to [GitHub issues](https://github.com/apache/arrow/issues) and click on **New issue** . -To be assigned to an unassigned issue, add a comment "take" to that issue. +To be assigned to an issue, leave a comment on that issue saying you would +like to work on it, and a committer or collaborator will assign it to you. Before you create a new bug entry, we recommend you first search among existing Arrow issues in diff --git a/docs/source/developers/bug_reports.rst b/docs/source/developers/bug_reports.rst index e1c8e769ba8e..3f856688d38f 100644 --- a/docs/source/developers/bug_reports.rst +++ b/docs/source/developers/bug_reports.rst @@ -243,5 +243,7 @@ Issue assignment ++++++++++++++++ Assignment signals commitment to work on an issue, and contributors should -self-assign issues when that work starts. Anyone can self-assign an -unassigned issue by commenting ``take``. +be assigned to issues when that work starts. If you would like to work on an +issue, leave a comment saying so and a committer or collaborator will assign +it to you. See :ref:`collaborators` for how to get the ability to assign +issues yourself. diff --git a/docs/source/developers/guide/step_by_step/finding_issues.rst b/docs/source/developers/guide/step_by_step/finding_issues.rst index de686269a885..0284f6e93085 100644 --- a/docs/source/developers/guide/step_by_step/finding_issues.rst +++ b/docs/source/developers/guide/step_by_step/finding_issues.rst @@ -79,8 +79,8 @@ in the comments. When you find a GitHub issue you would like to work on, please mention your interest in the comment section of that issue; that way we will know - you are working on it. - Consider assigning yourself to the issue (:ref:`issue-assignment`) when the work starts. + you are working on it and can assign the issue to you + (see :ref:`issue-assignment`). Also, do not hesitate to ask questions in the comment. You can get some pointers about where to start and similar issues already solved. diff --git a/docs/source/developers/guide/tutorials/python_tutorial.rst b/docs/source/developers/guide/tutorials/python_tutorial.rst index 3838acb9fcf3..5b8256c8bd28 100644 --- a/docs/source/developers/guide/tutorials/python_tutorial.rst +++ b/docs/source/developers/guide/tutorials/python_tutorial.rst @@ -89,9 +89,10 @@ With a GitHub account created we will navigate to the `GitHub issue dashboard `_ and click on the **New issue** button. -We should make sure to assign ourselves to the issue to let others -know we are working on it. You can do that with adding a comment -``take`` to the issue created. +We should make sure to let others know we are working on the issue. +You can do that by adding a comment to the issue created saying you +would like to work on it, and a committer or collaborator will assign +it to you. .. seealso:: diff --git a/docs/source/developers/reviewing.rst b/docs/source/developers/reviewing.rst index 1550d6aa7ce6..c0fcf56155d8 100644 --- a/docs/source/developers/reviewing.rst +++ b/docs/source/developers/reviewing.rst @@ -296,6 +296,8 @@ In addition, we use the following labels to indicate priority: superset of issues marked "Critical Fix", as it also contains certain fixes to issues causing errors and crashes. +.. _collaborators: + Collaborators =============