SSH Key pairs links should use the unique ID instead of the name

[bugoff]

ISSUE TYPE

• Bug Report

COMPONENT NAME

UI - ssh key pairs

CLOUDSTACK VERSION

4.17.0

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

I added my ssh key pair on multiple accounts / domains. They have the same name which causes the ui to only pick te first.

STEPS TO REPRODUCE

Add the same key under multiple accounts and try to click the last one. It will open the first entry.

EXPECTED RESULTS

I think the ui should use the ID instead of the name.

ACTUAL RESULTS

[utchoang]

As far as I know, the return result of listSSHKeyPairs has 2 types: with id and without id. This makes the conversion to only id impossible. What do you think? @shwstppr cc @rohityadavcloud @Pearl1594

[shwstppr]

UUID for SSHKeyPair was added only in 4.16.0. https://github.com/apache/cloudstack/pull/5103/files#diff-57c8dd809042b11cd4a14741e2f797e968f23a9cc7bf7b875864397f32d68582R32-R35
Keypairs added earlier than that do not have UUID. This is why they are listed using the name.
@utchoang we may do something like the following but this would solve it only for keypair list. This won't work infocard as resource.keypair will only have the name

diff --git a/ui/src/components/view/ListView.vue b/ui/src/components/view/ListView.vue
index 292460541a..981152fe21 100644
--- a/ui/src/components/view/ListView.vue
+++ b/ui/src/components/view/ListView.vue
@@ -98,7 +98,7 @@
         </span>
 
         <span v-if="record.hasannotations">
-          <span v-if="record.id && $route.path !== '/ssh'">
+          <span v-if="record.id">
             <router-link :to="{ path: $route.path + '/' + record.id }">{{ text }}</router-link>
             <router-link :to="{ path: $route.path + '/' + record.id, query: { tab: 'comments' } }"><message-filled style="padding-left: 10px" size="small"/></router-link>
           </span>
@@ -110,7 +110,7 @@
           <router-link :to="{ path: $route.path + '/' + record.name }" v-else>{{ $t(text.toLowerCase()) }}</router-link>
         </span>
         <span v-else>
-          <router-link :to="{ path: $route.path + '/' + record.id }" v-if="record.id && $route.path !== '/ssh'">{{ text }}</router-link>
+          <router-link :to="{ path: $route.path + '/' + record.id }" v-if="record.id">{{ text }}</router-link>
           <router-link :to="{ path: $route.path + '/' + record.name }" v-else>{{ text }}</router-link>
         </span>
       </span>
diff --git a/ui/src/views/AutogenView.vue b/ui/src/views/AutogenView.vue
index ff75a6d269..e8397c0b2d 100644
--- a/ui/src/views/AutogenView.vue
+++ b/ui/src/views/AutogenView.vue
@@ -851,8 +851,11 @@ export default {
       if (this.$route.params && this.$route.params.id) {
         params.id = this.$route.params.id
         if (['listSSHKeyPairs'].includes(this.apiName)) {
-          delete params.id
-          params.name = this.$route.params.id
+          const regexExp = /^[0-9a-fA-F]{8}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{12}$/gi
+          if (!regexExp.test(params.id)) {
+            delete params.id
+            params.name = this.$route.params.id
+          }
         }
         if (['listPublicIpAddresses'].includes(this.apiName)) {
           params.allocatedonly = false

[yadvr]

@shwstppr should we raise a PR? For example, when name is missing use uuid in the list, and allow users to update/rename their keys?

[shwstppr]

@rohityadavcloud it won't be simple. It is not the name that is missing. SSH keypairs added before 4.16 don't have UUIDs and many API responses have the parameter keypair which returns the name of the keypair. As I mentioned, we can fix it in keypair list view in UI but when a keypair is navigated from the info card of another resource it may still use the name.

[shwstppr]

@bugoff issue you face should be fixed by #6616 if the keys were added after 4.16.0
Please reopen if you still face the issue