UI bug: Fail to deploy vm if override disk offering is dynamic

[weizhouapache]

This impacts 4.17 and main branch.

steps to reproduce the issue

• open deploy vm wizard
• click 'Override root disk offering'
• choose a 'Custom' disk offeirng
• input 'Root disk size (GB)' in the 'Override root disk offering' section (e.g. 10GB)
• deploy vm.

expected result: deploy vm with root disk size = 10GB
actual result: error: "VM Creation failed. Volume size: -1GB is out of allowed range. Max: 1024 Min:1"

I checked the log, the API request does not have 'rootdisksize'. so it seems to be a UI bug.

zoneid=d42cdbd9-b507-4355-8b03-fe8cfa877529&boottype=BIOS&bootmode=LEGACY&templateid=8c2be286-e7c3-11ec-8653-1e007b000350&hypervisor=KVM&startvm=true&serviceofferingid=2bff76dc-e94d-4616-807a-282ca4415739&overridediskofferingid=6778c653-55fc-4b9e-a035-38d1ce3dd683&diskofferingid=6778c653-55fc-4b9e-a035-38d1ce3dd683&size=2&affinitygroupids=&iptonetworklist[0].networkid=ddbeeef4-2998-4084-8354-2eb0218dd493&keypairs=&name=admin-003&displayname=admin-003&command=deployVirtualMachine&response=json

ISSUE TYPE

• Bug Report

COMPONENT NAME

UI

CLOUDSTACK VERSION

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

[weizhouapache]

thanks @shwstppr