diff --git a/gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala index 42005b8709a..cb795fd7c7c 100644 --- a/gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala +++ b/gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala @@ -104,8 +104,6 @@ class VeloxTestSettings extends BackendTestSettings { .exclude("SPARK-35719: cast timestamp with local time zone to timestamp without timezone") // Revised by setting timezone through config and commented unsupported cases. .exclude("cast string to timestamp") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type in ansi mode") enableSuite[GlutenArithmeticExpressionSuite] enableSuite[GlutenBitwiseExpressionsSuite] enableSuite[GlutenCastSuite] @@ -121,8 +119,6 @@ class VeloxTestSettings extends BackendTestSettings { // Revised by setting timezone through config and commented unsupported cases. .exclude("cast string to timestamp") .exclude("SPARK-36286: invalid string cast to timestamp") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type") enableSuite[GlutenCollectionExpressionsSuite] // Rewrite in Gluten to replace Seq with Array .exclude("Shuffle") diff --git a/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala index fe92e16ce66..c4cf33738a5 100644 --- a/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala +++ b/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala @@ -100,8 +100,6 @@ class VeloxTestSettings extends BackendTestSettings { .exclude("cast from timestamp II") .exclude("SPARK-36286: invalid string cast to timestamp") .exclude("SPARK-39749: cast Decimal to string") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type") enableSuite[GlutenTryCastSuite] .exclude( "Process Infinity, -Infinity, NaN in case insensitive manner" // +inf not supported in folly. @@ -119,8 +117,6 @@ class VeloxTestSettings extends BackendTestSettings { .exclude("cast string to timestamp") // TODO: fix after https://github.com/facebookincubator/velox/pull/14910 .exclude("SPARK-39749: cast Decimal to string") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type in ansi mode") enableSuite[GlutenCollectionExpressionsSuite] // Rewrite in Gluten to replace Seq with Array .exclude("Shuffle") diff --git a/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala index 0680080345f..b602c175527 100644 --- a/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala +++ b/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala @@ -104,8 +104,6 @@ class VeloxTestSettings extends BackendTestSettings { .exclude("cast from timestamp II") .exclude("SPARK-36286: invalid string cast to timestamp") .exclude("SPARK-39749: cast Decimal to string") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type") enableSuite[GlutenTryCastSuite] .exclude( "Process Infinity, -Infinity, NaN in case insensitive manner" // +inf not supported in folly. @@ -123,8 +121,6 @@ class VeloxTestSettings extends BackendTestSettings { .exclude("cast string to timestamp") // TODO: fix after https://github.com/facebookincubator/velox/pull/14910 .exclude("SPARK-39749: cast Decimal to string") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type in ansi mode") enableSuite[GlutenCollectionExpressionsSuite] // Rewrite in Gluten to replace Seq with Array .exclude("Shuffle") diff --git a/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala index 050aef8aa06..5d6a7b4321e 100644 --- a/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala +++ b/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala @@ -116,8 +116,6 @@ class VeloxTestSettings extends BackendTestSettings { .exclude("cast from timestamp II") .exclude("SPARK-36286: invalid string cast to timestamp") .exclude("SPARK-39749: cast Decimal to string") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type") enableSuite[GlutenTryCastSuite] .exclude( "Process Infinity, -Infinity, NaN in case insensitive manner" // +inf not supported in folly. @@ -135,8 +133,6 @@ class VeloxTestSettings extends BackendTestSettings { .exclude("cast string to timestamp") // TODO: fix after https://github.com/facebookincubator/velox/pull/14910 .exclude("SPARK-39749: cast Decimal to string") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type in ansi mode") enableSuite[GlutenCollectionExpressionsSuite] // Rewrite in Gluten to replace Seq with Array .exclude("Shuffle") diff --git a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala index 1f6919774d7..68a957c2485 100644 --- a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala +++ b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala @@ -120,8 +120,6 @@ class VeloxTestSettings extends BackendTestSettings { .exclude("cast from timestamp II") .exclude("SPARK-36286: invalid string cast to timestamp") .exclude("SPARK-39749: cast Decimal to string") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type") enableSuite[GlutenTryCastSuite] .exclude( "Process Infinity, -Infinity, NaN in case insensitive manner" // +inf not supported in folly. @@ -139,8 +137,6 @@ class VeloxTestSettings extends BackendTestSettings { .exclude("cast string to timestamp") // TODO: fix after https://github.com/facebookincubator/velox/pull/14910 .exclude("SPARK-39749: cast Decimal to string") - // See https://github.com/facebookincubator/velox/issues/17593. - .exclude("Fast fail for cast string type to decimal type in ansi mode") enableSuite[GlutenCollectionExpressionsSuite] // Rewrite in Gluten to replace Seq with Array .exclude("Shuffle")