From 7034f74af4c51617f5fdd2f9ffa576f14babaead Mon Sep 17 00:00:00 2001 From: Vincent Potucek Date: Wed, 21 May 2025 13:58:53 +0200 Subject: [PATCH 1/2] fix unused `@SuppressWarnings("checkstyle:UnusedLocalVariable")` --- .../java/org/apache/maven/plugin/coreit/PropertiesUtil.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java b/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java index 9d0a9a4414f5..fb69efc94ef6 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java @@ -104,9 +104,7 @@ public static void serialize(Properties props, String key, Object value) { } else if (value instanceof Map) { Map map = (Map) value; props.setProperty(key, Integer.toString(map.size())); - @SuppressWarnings("checkstyle:UnusedLocalVariable") - int i = 0; - for (Iterator it = map.keySet().iterator(); it.hasNext(); i++) { + for (Iterator it = map.keySet().iterator(); it.hasNext();) { Object k = it.next(); Object v = map.get(k); serialize(props, key + "." + k, v); From 0e993f4619e053a0609976323e099d78d17194bd Mon Sep 17 00:00:00 2001 From: Vincent Potucek Date: Wed, 21 May 2025 14:00:07 +0200 Subject: [PATCH 2/2] fix unused `@SuppressWarnings("checkstyle:UnusedLocalVariable")` --- .../java/org/apache/maven/plugin/coreit/PropertiesUtil.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java b/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java index fb69efc94ef6..6bbe8774665c 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java @@ -101,11 +101,9 @@ public static void serialize(Properties props, String key, Object value) { for (Iterator it = collection.iterator(); it.hasNext(); i++) { serialize(props, key + "." + i, it.next()); } - } else if (value instanceof Map) { - Map map = (Map) value; + } else if (value instanceof Map map) { props.setProperty(key, Integer.toString(map.size())); - for (Iterator it = map.keySet().iterator(); it.hasNext();) { - Object k = it.next(); + for (Object k : map.keySet()) { Object v = map.get(k); serialize(props, key + "." + k, v); }