Skip to content

Commit a51b207

Browse files
committed
test(realtime): remove redundant close coverage
1 parent a77b5f4 commit a51b207

2 files changed

Lines changed: 2 additions & 25 deletions

File tree

src/paimon/core/mergetree/merge_tree_writer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,11 @@ Status MergeTreeWriter::WriteSortedReadersToFiles(
172172
}
173173
}
174174

175-
// 2. prepare loser tree sort merge reader
175+
// prepare loser tree sort merge reader
176176
auto sort_merge_reader = std::make_unique<SortMergeReaderWithLoserTree>(
177177
std::move(readers), key_comparator_, user_defined_seq_comparator_, merge_function_wrapper_);
178178
raw_readers_guard.Release();
179-
// 3. project key value to arrow array
179+
// project key value to arrow array
180180
auto create_consumer = [target_schema = write_schema_, pool = pool_]()
181181
-> Result<std::unique_ptr<RowToArrowArrayConverter<KeyValue, KeyValueBatch>>> {
182182
return KeyValueMetaProjectionConsumer::Create(target_schema, pool);

src/paimon/core/realtime/realtime_primary_key_reader_test.cpp

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -685,27 +685,4 @@ TEST_F(RealtimePrimaryKeyReaderTest, TestFactoryFailureClosesReaders) {
685685
ASSERT_EQ(factory_failure_close_count, 1);
686686
}
687687

688-
TEST_F(RealtimePrimaryKeyReaderTest, TestQueryReaderClose) {
689-
std::vector<DataField> value_fields = {DataField(0, arrow::field("k0", arrow::int32())),
690-
DataField(1, arrow::field("v0", arrow::int32()))};
691-
std::shared_ptr<arrow::Schema> value_schema =
692-
DataField::ConvertDataFieldsToArrowSchema(value_fields);
693-
std::shared_ptr<arrow::Schema> key_schema = arrow::schema({value_schema->field(0)});
694-
std::shared_ptr<arrow::Schema> transport_schema = MakeTransportSchema(value_schema->fields());
695-
std::shared_ptr<arrow::DataType> transport_type = arrow::struct_(transport_schema->fields());
696-
std::shared_ptr<arrow::Array> transport_array =
697-
arrow::ipc::internal::json::ArrayFromJSON(transport_type, R"([[0, 10, 0, 1, 100]])")
698-
.ValueOrDie();
699-
700-
int32_t close_count = 0;
701-
auto batch_reader = std::make_unique<TrackingBatchReader>(
702-
std::make_unique<MockFileBatchReader>(transport_array, transport_type, 1), &close_count);
703-
ASSERT_OK_AND_ASSIGN(std::unique_ptr<KeyValueRecordReader> reader,
704-
CreateRealtimePrimaryKeyQueryReaderForTest(
705-
std::move(batch_reader), transport_schema, OffsetRange(0, 1),
706-
key_schema, value_schema, pool_));
707-
reader->Close();
708-
ASSERT_EQ(close_count, 1);
709-
}
710-
711688
} // namespace paimon::test

0 commit comments

Comments
 (0)