Allow changing of spec.sync.image value after creating the deployment (#1095)

nikita-vanyasin · web-flow · commit ad03acb55c1a · 2022-08-31T15:41:38.000+02:00
diff --git a/pkg/apis/deployment/v1/sync_spec.go b/pkg/apis/deployment/v1/sync_spec.go
@@ -106,8 +106,5 @@ func (s SyncSpec) ResetImmutableFields(fieldPrefix string, target *SyncSpec) []s
 	if list := s.Authentication.ResetImmutableFields(fieldPrefix+".auth", &target.Authentication); len(list) > 0 {
 		resetFields = append(resetFields, list...)
 	}
-	if s.GetSyncImage() != target.GetSyncImage() {
-		resetFields = append(resetFields, fieldPrefix+".image")
-	}
 	return resetFields
 }
diff --git a/pkg/apis/deployment/v2alpha1/sync_spec.go b/pkg/apis/deployment/v2alpha1/sync_spec.go
@@ -106,8 +106,5 @@ func (s SyncSpec) ResetImmutableFields(fieldPrefix string, target *SyncSpec) []s
 	if list := s.Authentication.ResetImmutableFields(fieldPrefix+".auth", &target.Authentication); len(list) > 0 {
 		resetFields = append(resetFields, list...)
 	}
-	if s.GetSyncImage() != target.GetSyncImage() {
-		resetFields = append(resetFields, fieldPrefix+".image")
-	}
 	return resetFields
 }

Original file line number	Diff line number	Diff line change
`@@ -106,8 +106,5 @@ func (s SyncSpec) ResetImmutableFields(fieldPrefix string, target *SyncSpec) []s`
`106`	`106`	`if list := s.Authentication.ResetImmutableFields(fieldPrefix+".auth", &target.Authentication); len(list) > 0 {`
`107`	`107`	`resetFields = append(resetFields, list...)`
`108`	`108`	`}`
`109`		`- if s.GetSyncImage() != target.GetSyncImage() {`
`110`		`- resetFields = append(resetFields, fieldPrefix+".image")`
`111`		`- }`
`112`	`109`	`return resetFields`
`113`	`110`	`}`