Use ArangoMember as owner reference for syncmaster secrets instead of Deployment (#1394)

nikita-vanyasin · web-flow · commit ae2c48e6d47c · 2023-09-15T11:06:54.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@
 - (Bugfix) Fix PVC Rotation Discovery
 - (Feature) Allow to pass EphemeralStorage Resource to the Pods
 - (Feature) Add basic metrics for ArangoDeploymentReplication CR
+- (Bugfix) Use ArangoMember as owner reference for syncmaster secrets instead of Deployment
 
 ## [1.2.32](https://github.com/arangodb/kube-arangodb/tree/1.2.32) (2023-08-07)
 - (Feature) Backup lifetime - remove Backup once its lifetime has been reached
diff --git a/pkg/deployment/resources/pod_creator.go b/pkg/deployment/resources/pod_creator.go
@@ -518,7 +518,7 @@ func (r *Resources) createPodForMember(ctx context.Context, cachedStatus inspect
 				return errors.WithStack(errors.Wrapf(err, "Failed to render alt names"))
 			}
 
-			owner := apiObject.AsOwner()
+			owner := arangoMember.AsOwner()
 			_, err = createTLSServerCertificate(ctx, log, cachedStatus, cachedStatus.SecretsModInterface().V1(), names, spec.Sync.TLS, tlsKeyfileSecretName, &owner)
 			if err != nil && !kerrors.IsAlreadyExists(err) {
 				return errors.WithStack(errors.Wrapf(err, "Failed to create TLS keyfile secret"))

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,7 @@ func (r *Resources) createPodForMember(ctx context.Context, cachedStatus inspect`
`518`	`518`	`return errors.WithStack(errors.Wrapf(err, "Failed to render alt names"))`
`519`	`519`	`}`
`520`	`520`
`521`		`- owner := apiObject.AsOwner()`
	`521`	`+ owner := arangoMember.AsOwner()`
`522`	`522`	`_, err = createTLSServerCertificate(ctx, log, cachedStatus, cachedStatus.SecretsModInterface().V1(), names, spec.Sync.TLS, tlsKeyfileSecretName, &owner)`
`523`	`523`	`if err != nil && !kerrors.IsAlreadyExists(err) {`
`524`	`524`	`return errors.WithStack(errors.Wrapf(err, "Failed to create TLS keyfile secret"))`