Skip to content

Commit 4cd6dfc

Browse files
committed
misc: warning cleanup
Remove a few warnings about unused parameters, uninitialized variables and signed/unsigned mismatches detected by CI runs. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
1 parent bf18094 commit 4cd6dfc

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/monitor.h

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ class BridgeMonitor: public Stream {
3838
using Print::write;
3939

4040
bool begin(unsigned long _legacy_baud=0, uint16_t _legacy_config=0) {
41+
// unused parameters for compatibility with Stream
42+
(void)_legacy_baud;
43+
(void)_legacy_config;
44+
4145
k_mutex_init(&monitor_mutex);
4246

4347
if (is_connected()) return true;
@@ -68,19 +72,19 @@ class BridgeMonitor: public Stream {
6872
}
6973

7074
int read() override {
71-
uint8_t c;
75+
uint8_t c = 0;
7276
read(&c, 1);
7377
return c;
7478
}
7579

7680
int read(uint8_t* buffer, size_t size) {
7781
k_mutex_lock(&monitor_mutex, K_FOREVER);
78-
int i = 0;
82+
size_t i = 0;
7983
while (temp_buffer.available() && i < size) {
8084
buffer[i++] = temp_buffer.read_char();
8185
}
8286
k_mutex_unlock(&monitor_mutex);
83-
return i;
87+
return (int)i;
8488
}
8589

8690
int available() override {
@@ -164,4 +168,4 @@ extern BridgeClass Bridge;
164168

165169
inline BridgeMonitor<> Monitor(Bridge);
166170

167-
#endif // BRIDGE_MONITOR_H
171+
#endif // BRIDGE_MONITOR_H

src/tcp_client.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ class BridgeTCPClient : public Client {
132132

133133
int read(uint8_t *buf, size_t size) override {
134134
k_mutex_lock(&client_mutex, K_FOREVER);
135-
int i = 0;
135+
size_t i = 0;
136136
while (temp_buffer.available() && i < size) {
137137
buf[i++] = temp_buffer.read_char();
138138
}
139139
k_mutex_unlock(&client_mutex);
140-
return i;
140+
return (int)i;
141141
}
142142

143143
int peek() override {

0 commit comments

Comments
 (0)