warning cleanup: misc fixes

- Arduino_LED_Matrix: fix packed attribute placement, add missing dependency
- Camera: fix pixel format check (formats are uint32_t, not pointers)
- Ethernet: fix float division literals
- SocketWrapper: hide deprecated warnings, fix signed/unsigned compare
- Wire: hide pedantic 'invalid offsetof' warning

Author: pillo79

libraries/Arduino_LED_Matrix/examples/Reflash_Bootanimation/bootanimation.h

@@ -1,12 +1,12 @@
 #include "stdint.h"
 
-__attribute__((packed)) struct bootanimation_user_data {
+struct bootanimation_user_data {
 	size_t magic; // must be 0xBA for bootanimation
 	size_t len_loop;
 	size_t len_end;
 	size_t empty;
 	uint8_t *buf_loop;
-};
+} __attribute__((packed));
 
 unsigned int bootanimation_end_len = 3120;
 unsigned int bootanimation_len = 18720;

libraries/Arduino_LED_Matrix/library.properties

@@ -7,4 +7,4 @@ paragraph=This library provides a simple interface for controlling the LED matri
 category=Communication
 url=https://www.arduino.cc/
 architectures=*
-depends=
+depends=ArduinoGraphics

libraries/Camera/src/camera.cpp

@@ -78,13 +78,13 @@ bool Camera::begin(uint32_t width, uint32_t height, uint32_t pixformat, bool byt
 		return false;
 	}
 
-	for (size_t i = 0; caps.format_caps[i].pixelformat != NULL; i++) {
+	for (size_t i = 0; caps.format_caps[i].pixelformat != 0; i++) {
 		const struct video_format_cap *fcap = &caps.format_caps[i];
 		if (fcap->width_min == width && fcap->height_min == height &&
 			fcap->pixelformat == pixformat) {
 			break;
 		}
-		if (caps.format_caps[i + 1].pixelformat == NULL) {
+		if (caps.format_caps[i + 1].pixelformat == 0) {
 			Serial.println("The specified format is not supported");
 			return false;
 		}

libraries/Ethernet/examples/WebClient/WebClient.ino

@@ -110,10 +110,10 @@ void loop() {
     Serial.print("Received ");
     Serial.print(byteCount);
     Serial.print(" bytes in ");
-    float seconds = (float)(endMicros - beginMicros) / 1000000.0;
+    float seconds = (endMicros - beginMicros) / 1000000.0f;
     Serial.print(seconds, 4);
-    float rate = (float)byteCount / seconds / 1000.0;
     Serial.print(", rate = ");
+    float rate = byteCount / 1000.0f / seconds;
     Serial.print(rate);
     Serial.print(" kbytes/second");
     Serial.println();

libraries/SocketWrapper/SocketHelpers.cpp

@@ -179,7 +179,12 @@ void NetworkInterface::setLocalIP(const IPAddress ip) {
 void NetworkInterface::setSubnetMask(const IPAddress subnet) {
 	struct in_addr netmask_addr;
 	netmask_addr.s_addr = subnet;
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+	// TODO: store the address that was manually set and replace this call
+	// with net_if_ipv4_set_netmask_by_addr
 	net_if_ipv4_set_netmask(netif, &netmask_addr);
+#pragma GCC diagnostic pop
 	LOG_INF("Subnet mask set: %s", subnet.toString().c_str());
 	return;
 }

libraries/SocketWrapper/ZephyrUDP.h

@@ -269,7 +269,7 @@ class ZephyrUDP : public arduino::UDP {
 	IPAddress _send_to_ip;
 	uint16_t _send_to_port;
 	std::vector<uint8_t> _tx_data;
-	int _rx_pkt_list_size = 10;
+	size_t _rx_pkt_list_size = 10;
 
 	/* UDP RECEPTION */
 	class UdpRxPacket {

libraries/Wire/Wire.cpp

@@ -10,8 +10,11 @@
 
 // Helper function to get ZephyrI2C instance from config pointer.
 static arduino::ZephyrI2C *getInstance(struct i2c_target_config *config) {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Winvalid-offsetof"
 	return reinterpret_cast<arduino::ZephyrI2C *>(reinterpret_cast<char *>(config) -
 												  offsetof(arduino::ZephyrI2C, i2c_cfg));
+#pragma GCC diagnostic pop
 }
 
 static int i2c_target_stop_cb(struct i2c_target_config *config) {