Minor

Author: martacarbone

debian/arduino-app-cli/DEBIAN/postinst

@@ -1,6 +1,5 @@
 #!/bin/sh
 
-#chown -R arduino:arduino /home/arduino/.local/share/arduino-app-cli
 mkdir /var/cache/arduino-app-cli
 chown -R arduino:arduino /var/cache/arduino-app-cli
 mkdir /home/arduino/.arduino-app-cli

debian/arduino-app-cli/DEBIAN/postrm

@@ -1,6 +1,5 @@
 #!/bin/sh
 
-# TODO delete /var/cache
 rm -rf /var/cache/arduino-app-cli
 
 if [ -d /run/systemd/system ]; then

docs/user-documentation.md

@@ -7,7 +7,7 @@ The following environment variables are used to configure Arduino App CLI:
 | Environment Variable                   | Default Value                                    | Description                                                                        |
 | -------------------------------------- | ------------------------------------------------ | ---------------------------------------------------------------------------------- |
 | `ARDUINO_APP_CLI__APPS_DIR`            | `/home/arduino/ArduinoApps`                      | Path to the directory where Arduino Apps created by the user are stored            |
-| `ARDUINO_APP_CLI__DATA_DIR`            | `/home/arduino/.local/share/arduino-app-cli`     | Path to the directory where internal data is stored (examples, assets, properties) |
+| `ARDUINO_APP_CLI__DATA_DIR`            | `/usr/share/arduino-app-cli`                     | Path to the directory where internal data is stored (examples, assets) |
 | `ARDUINO_APP_BRICKS__CUSTOM_MODEL_DIR` | `$HOME/.arduino-bricks/ei-models`                | Path to the directory where custom AI models are stored                            |
 | `ARDUINO_APP_CLI__ALLOW_ROOT`          | `false`                                          | Allow running `arduino-app-cli` as root (**Not recommended to set to true**)       |
 | `LIBRARIES_API_URL`                    | `https://api2.arduino.cc/libraries/v1/libraries` | URL of the external service used to search Arduino libraries                       |
@@ -33,19 +33,14 @@ Examples of user-defined Arduino Apps stored under the `ARDUINO_APP_CLI__APPS_DI
     ├── python
         └── main.py
 ```
-
-Examples of the `assets` and the builtin `examples` stored under the `ARDUINO_APP_CLI__DATA_DIR` folder.
-
+Examples of the `assets` and the builtin `examples` are stored under the `ARDUINO_APP_CLI__DATA_DIR` folder.
 ```
-/home/arduino/.local/share/arduino-app-cli/
+/usr/share/arduino-app-cli/
 ├── assets
 │   └── 0.5.0                 # Version-specific assets
 │       ├── bricks-list.yaml  # Available bricks
 │       ├── models-list.yaml  # Available models
 │       └── ...
-├── bootloader_burned.flag
-├── default.app               # Default App
-├── properties.msgpack        # Variable values
 ├── examples                  # Built-in App examples
 │   ├── air-quality-monitoring
 │   │   ├── app.yaml
@@ -60,3 +55,6 @@ Examples of the `assets` and the builtin `examples` stored under the `ARDUINO_AP
 │   │   └── README.md
 │   └── ...
 ```
+
+Package configurations are located in ```/home/arduino/.arduino-app-cli```
+Runtime data are other files are in ```/var/lib/arduino-app-cli```

internal/api/handlers/properties.go

@@ -30,10 +30,10 @@ import (
 )
 
 func getPropertiesDir() string {
-	xdgHome, _ := os.UserHomeDir()
-	//if err != nil {
-	//	slog.Error("Unable to retrieve list", slog.String("error", err.Error()))
-	//}
+	xdgHome, err := os.UserHomeDir()
+	if err != nil {
+		slog.Error("Unable to set user home", slog.String("error", err.Error()))
+	}
 	return paths.New(xdgHome).Join(".arduino-app-cli", "properties.msgpack").String()
 }
 

internal/orchestrator/config/config.go

@@ -63,13 +63,7 @@ func NewFromEnv() (Configuration, error) {
 
 	dataDir := paths.New(os.Getenv("ARDUINO_APP_CLI__DATA_DIR"))
 	if dataDir == nil {
-		dataDir = paths.New("/", "usr", "share", "arduino-app-cli")
-		slog.Info("ARDUINO_APP_CLI__DATA_DIR unset, use default", slog.String("ARDUINO_APP_CLI__DATA_DIR", dataDir.String()))
-		if dataDir == nil {
-			return Configuration{}, errors.New("unable to create data dir")
-		}
-	} else {
-		slog.Info("ARDUINO_APP_CLI__DATA_DIR override", slog.String("ARDUINO_APP_CLI__DATA_DIR", dataDir.String()))
+		dataDir = paths.New("/usr/share/arduino-app-cli")
 	}
 
 	routerSocket := paths.New(os.Getenv("ARDUINO_ROUTER_SOCKET"))