Commit d229d0b
committed
Remove misleading fqbn key from sketch build profile of new App template
When a new App is generated, it contains a sketch which in turn contains a build profile. Previously, the `fqbn` key of
this build profile was set to `arduino:zephyr:unoq`. Since the build profile is indeed used to control the dependencies
of the sketch, the user would be led to also believe that the FQBN specified in the build profile is used when compiling
and uploading the sketch. This is not so. An FQBN is instead hardcoded into the compilation and upload code, meaning the
`fqbn` key in the build profile has absolutely no effect.
The obvious problem with this is that it will lead the advanced user to believe they can configure the FQBN used by App
Lab via the `fqbn` key of the build profile. For example, they might wish to use the
`arduino:zephyr:unoq:flash_mode=flash,wait_linux_boot=no` FQBN in cases where the sketch code is not reliant on the
immediate availability of the Linux machine and they do not wish for the execution of the sketch program to be delayed
after power on.
Even more confusing is the fact that the `arduino:zephyr:unoq:flash_mode=ram` FQBN used when uploading is different from
the FQBN the default build profile would lead the user to believe is in use (since the default value of the `flash_mode`
custom board option is `flash` NOT `ram`, and thus the `arduino:zephyr:unoq` used in the template is equivalent to
`arduino:zephyr:unoq:flash_mode=flash`).
Removing the unused and misleading `fqbn` key from the generated build profile will better communicate the actual
situation to the user.1 parent 51dab70 commit d229d0b
File tree
3 files changed
+2
-4
lines changed- internal/orchestrator
- app/generator
- app_template/sketch
- testdata/app-all.golden/sketch
3 files changed
+2
-4
lines changedLines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1187 | 1187 | | |
1188 | 1188 | | |
1189 | 1189 | | |
1190 | | - | |
1191 | | - | |
| 1190 | + | |
| 1191 | + | |
1192 | 1192 | | |
1193 | 1193 | | |
1194 | 1194 | | |
| |||
0 commit comments