fix: make app failed if a container is stopped #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulio93
force-pushed
the
add_stopped_state_to_app_status
branch
2 times, most recently
from
9be4ebb to
1bfe213
Compare
lucarin91
reviewed
Nov 27, 2025
giulio93
force-pushed
the
add_stopped_state_to_app_status
branch
5 times, most recently
from
dc07a7f to
09691b6
Compare
lucarin91
reviewed
Nov 28, 2025
Contributor
|
we should think of some test for this |
lucarin91
changed the title
lucarin91
requested changes
Nov 28, 2025
| containerState: []container.ContainerState{container.StateRunning, container.StateDead, container.StateRemoving, container.StateRestarting, container.StateExited}, | ||
| want: StatusFailed, | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
we should add a test for the new check
giulio93
force-pushed
the
add_stopped_state_to_app_status
branch
from
3db2a77 to
0243557
Compare
Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>
giulio93
force-pushed
the
add_stopped_state_to_app_status
branch
from
0243557 to
2549af2
Compare
lucarin91
requested changes
Dec 5, 2025
giulio93
force-pushed
the
add_stopped_state_to_app_status
branch
from
2549af2 to
a09d652
Compare
lucarin91
requested changes
Dec 5, 2025
internal/orchestrator/helpers.go
Outdated
| continue | ||
| } | ||
| if slices.ContainsFunc(s, func(v containerStateInfo) bool { | ||
| return v.State == StatusStopped && strings.Contains(v.StatusMessage, "Exited (0)") |
Contributor
There was a problem hiding this comment.
We should account for all exit codes that aren't signals, so everything that is less than 128
If you write an app with Python-like
exit(1)You say that this isn't a fail, which in fact it is, because the app exits right after be started.
lucarin91
reviewed
Dec 5, 2025
internal/orchestrator/helpers.go
Outdated
| } | ||
| appsStatusMap[appPath] = append(appsStatusMap[appPath], StatusFromDockerState(c.State)) | ||
| appsStatusMap[appPath] = append(appsStatusMap[appPath], containerStateInfo{ | ||
| State: StatusFromDockerState(c.State), |
Contributor
There was a problem hiding this comment.
Why don't you update this mapping function and don't account for the status message there? If a container exited with anything that isn't 128 + 9 we could consider that a failing state, because it means that the process exited without Docker killing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If at least a container of an application is stopped due to any reason, the application status should be failed.
In this way even if other containers are up and running the state of the application state is set as failed, and the user can debug the failed container.