From c413a5626a5d348622efad54611aa610ebec04b2 Mon Sep 17 00:00:00 2001 From: aminya Date: Fri, 24 Jul 2020 21:03:41 -0500 Subject: [PATCH 1/2] collect console log in renderer tests Print the output finally to ease diagnosing --- script/test | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/script/test b/script/test index 8c66a2ae925..99619102359 100755 --- a/script/test +++ b/script/test @@ -110,9 +110,21 @@ for (let testFile of testFiles) { '--resource-path', resourcePath, '--test', testFile ] - const cp = childProcess.spawn(executablePath, testArguments, {stdio: 'inherit', env: testEnv}) - cp.on('error', error => { callback(error) }) - cp.on('close', exitCode => { callback(null, {exitCode, step: `core-render-process for ${testFile}.`, testCommand: `You can run the test again using: \n\t ${executablePath} ${testArguments.join(' ')}`}) }) + const cp = childProcess.spawn(executablePath, testArguments, { env: testEnv}) + let stderrOutput = '' + cp.stderr.on('data', data => { stderrOutput += data }) + cp.stdout.on('data', data => { stderrOutput += data }) + cp.on('error', error => { + console.log(error, "error") + callback(error) + }) + cp.on('close', exitCode => { + if (exitCode !== 0) { + console.log(`##[error] Renderer tests failed for ${testFile}:`.red) + console.log(stderrOutput) + } + callback(null, {exitCode, step: `core-render-process for ${testFile}.`, testCommand: `You can run the test again using: \n\t ${executablePath} ${testArguments.join(' ')}`}) + }) }) } From 3bdd637ff28a1a4001cdd5d97193a10059b6e2fa Mon Sep 17 00:00:00 2001 From: aminya Date: Fri, 24 Jul 2020 21:03:55 -0500 Subject: [PATCH 2/2] Use async.series Revert b61475ffe420672b3360b50aba7b0f347ea319d4 --- script/test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/script/test b/script/test index 99619102359..930828430e5 100755 --- a/script/test +++ b/script/test @@ -281,7 +281,7 @@ function requestedTestSuites (platform) { return suites } -async.parallel(testSuitesToRun, function (err, results) { +async.series(testSuitesToRun, function (err, results) { if (err) { console.error(err) process.exit(1)