expands unit tests for make_expr safety

Author: attwoodn

tests/CMakeLists.txt

@@ -20,9 +20,9 @@ if(BUILD_TESTING)
     target_compile_options( expression_tree_test PRIVATE -fsanitize=address )
     add_test( expression_tree_test ${EXECUTABLE_OUTPUT_PATH}/expression_tree_test )
 
-    add_executable( examples examples.cpp )
-    target_link_libraries( examples "-fsanitize=address" )
-    target_compile_options( examples PRIVATE -fsanitize=address )
-    add_test( examples ${EXECUTABLE_OUTPUT_PATH}/examples )
+    add_executable( make_expr_safety_test make_expr_safety.cpp )
+    target_link_libraries( make_expr_safety_test "-fsanitize=address" )
+    target_compile_options( make_expr_safety_test PRIVATE -fsanitize=address )
+    add_test( make_expr_safety_test ${EXECUTABLE_OUTPUT_PATH}/make_expr_safety_test )
 
 endif()

tests/examples.cpp

@@ -0,0 +1,52 @@
+#include <attwoodn/expression_tree.hpp>
+#include <cassert>
+
+using namespace attwoodn::expression_tree;
+
+void make_expr_memory_safety_test();
+
+struct my_type {
+   int my_int = 5;
+   bool my_bool = true;
+};
+
+int main(int argc, char** argv) {
+    make_expr_memory_safety_test();
+
+    return EXIT_SUCCESS;
+}
+
+void make_expr_memory_safety_test() {
+
+    {
+        // The heap-allocated expression node pointer returned by make_expr becomes owned by the expression_tree
+        expression_tree<my_type> expr_tree_raw {
+            make_expr(&my_type::my_bool, op::equals, true)
+        };
+
+        expression_tree<my_type> expr_tree_raw_AND {
+            make_expr(&my_type::my_bool, op::equals, true)
+            ->AND(make_expr(&my_type::my_int, op::greater_than, 10))
+        };
+    }
+
+    {
+        // The heap-allocated expression node pointer returned by make_expr becomes owned by the unique_ptr
+        std::unique_ptr<node::expression_tree_node<my_type>> smart_expr {
+            make_expr(&my_type::my_bool, op::equals, true)
+        };
+
+        // the expression_tree takes ownership of the unique_ptr
+        expression_tree<my_type> expr_tree_smart(std::move(smart_expr));
+    }
+
+    {
+        // The heap-allocated expression node pointer returned by make_expr must be explicitly deleted
+        auto* expr_raw = make_expr(&my_type::my_bool, op::equals, true);
+        delete expr_raw;
+
+        auto* expr_raw_AND = make_expr(&my_type::my_bool, op::equals, true)
+                                ->AND(make_expr(&my_type::my_int, op::greater_than, 10));
+        delete expr_raw_AND;
+    }
+}