fix(sdk): comprehensive ESLint and TSDoc compliance improvements (#86)

- Remove 'any' type defaults from withDurableFunctions generic
parameters
- Replace 'any' with 'unknown' in logger interfaces for better type
safety
- Add missing return type annotations across test files and utility
functions
- Remove unused variable assignments and rename unused parameters with
underscore prefix
- Fix destructuring assignments to only capture needed variables
- Add eslint-disable comments for legitimate console.log usage in tests
and loggers
- Escape greater-than characters in TSDoc comments to prevent HTML tag
confusion
- Fix TSDoc parameter documentation with proper hyphen formatting

Co-authored-by: Pooya Paridel <parpooya@amazon.com>

Author: ParidelPooya

packages/aws-durable-execution-sdk-js-testing/src/test-runner/local/__tests__/integration/wait-for-callback-operations.integration.test.ts

@@ -17,7 +17,7 @@ describe("WaitForCallback Operations Integration", () => {
   it("should handle basic waitForCallback with anonymous submitter", async () => {
     let receivedCallbackId: string | undefined;
 
-    const handler = withDurableFunctions(
+    const handler = withDurableFunctions<unknown, unknown>(
       async (_event: unknown, context: DurableContext) => {
         const result = await context.waitForCallback<{ data: string }>(
           async (callbackId) => {
@@ -67,7 +67,7 @@ describe("WaitForCallback Operations Integration", () => {
 
   it("should handle basic waitForCallback with named submitter", async () => {
     let receivedCallbackId: string | undefined; // simulates a side-effect since it's outside the handler
-    const handler = withDurableFunctions(
+    const handler = withDurableFunctions<unknown, unknown>(
       async (_event: unknown, context: DurableContext) => {
         const result = await context.waitForCallback<{ data: string }>(
           async (callbackId) => {
@@ -116,7 +116,7 @@ describe("WaitForCallback Operations Integration", () => {
   // Error Handling & Submitter Function Variants Category
   describe("Error Handling & Submitter Function Variants", () => {
     it("should handle waitForCallback with submitter function synchronous errors", async () => {
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           try {
             const result = await context.waitForCallback<{ data: string }>(
@@ -160,7 +160,7 @@ describe("WaitForCallback Operations Integration", () => {
     });
 
     it("should handle waitForCallback with submitter function returning rejected promises", async () => {
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           try {
             const result = await context.waitForCallback<{ data: string }>(
@@ -206,7 +206,7 @@ describe("WaitForCallback Operations Integration", () => {
     it("should handle waitForCallback with callback failure scenarios", async () => {
       let receivedCallbackId: string | undefined;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           try {
             const result = await context.waitForCallback<{ data: string }>(
@@ -271,7 +271,7 @@ describe("WaitForCallback Operations Integration", () => {
       let scenario2CallbackId: string | undefined;
 
       // Test scenario where submitter fails but callback would have succeeded
-      const handler1 = withDurableFunctions(
+      const handler1 = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           try {
             const result = await context.waitForCallback<{ data: string }>(
@@ -310,7 +310,7 @@ describe("WaitForCallback Operations Integration", () => {
 
       // Test scenario where submitter succeeds but callback fails (covered in previous test)
       // This test demonstrates the contrast between the two scenarios
-      const handler2 = withDurableFunctions(
+      const handler2 = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           const result = await context.waitForCallback<{ data: string }>(
             (callbackId) => {
@@ -361,7 +361,7 @@ describe("WaitForCallback Operations Integration", () => {
       let callbackId: string | undefined;
       let sideEffectCounter = 0;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           try {
             const result = await context.waitForCallback<{ data: string }>(
@@ -439,7 +439,7 @@ describe("WaitForCallback Operations Integration", () => {
     it("should handle waitForCallback with heartbeat timeout configuration", async () => {
       let receivedCallbackId: string | undefined;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           const result = await context.waitForCallback<{ data: string }>(
             async (callbackId) => {
@@ -508,7 +508,7 @@ describe("WaitForCallback Operations Integration", () => {
       let submitterStartTime: number;
       let submitterEndTime: number;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           const result = await context.waitForCallback<{ processed: number }>(
             async (callbackId) => {
@@ -586,7 +586,7 @@ describe("WaitForCallback Operations Integration", () => {
 
     // Skip timeout scenarios until SDK properly supports them (similar to callback-operations.integration.test.ts)
     it.skip("should handle waitForCallback timeout scenarios", async () => {
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           try {
             const result = await context.waitForCallback<{ data: string }>(
@@ -636,7 +636,7 @@ describe("WaitForCallback Operations Integration", () => {
       let callback2Id: string | undefined;
       let callback3Id: string | undefined;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           // Start multiple waitForCallback operations concurrently
           const [result1, result2, result3] = await Promise.all([
@@ -756,7 +756,7 @@ describe("WaitForCallback Operations Integration", () => {
     it.skip("should handle waitForCallback mixed with steps, waits, and other operations", async () => {
       let callbackId: string | undefined;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           // Mix waitForCallback with other operation types
           await context.wait("initial-wait", 50);
@@ -843,7 +843,7 @@ describe("WaitForCallback Operations Integration", () => {
       let parentCallbackId: string | undefined;
       let childCallbackId: string | undefined;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           const parentResult = await context.waitForCallback<{
             parentData: string;
@@ -945,7 +945,7 @@ describe("WaitForCallback Operations Integration", () => {
       let firstCallbackId: string | undefined;
       let secondCallbackId: string | undefined;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           await context.wait("wait-invocation-1", 1000);
 
@@ -1048,7 +1048,7 @@ describe("WaitForCallback Operations Integration", () => {
       let innerCallbackId: string | undefined;
       let nestedCallbackId: string | undefined;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           const outerResult = await context.waitForCallback<{ level: string }>(
             "outer-callback-op",
@@ -1192,7 +1192,7 @@ describe("WaitForCallback Operations Integration", () => {
     it("should handle waitForCallback with custom timeout settings", async () => {
       let receivedCallbackId: string | undefined;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           const result = await context.waitForCallback<{ data: string }>(
             "custom-timeout-callback",
@@ -1307,7 +1307,7 @@ describe("WaitForCallback Operations Integration", () => {
       let receivedCallbackId: string | undefined;
       let submitterData: CustomData | undefined;
 
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           const result = await context.waitForCallback<CustomData>(
             "custom-serdes-callback",
@@ -1396,7 +1396,7 @@ describe("WaitForCallback Operations Integration", () => {
 
   describe("Mocking Tests", () => {
     it("should handle basic waitForCallback mocking functionality", async () => {
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           const result1 = await context.waitForCallback<{ data: string }>(
             "mock-callback-1",
@@ -1460,7 +1460,7 @@ describe("WaitForCallback Operations Integration", () => {
     });
 
     it("should handle waitForCallback error mocking", async () => {
-      const handler = withDurableFunctions(
+      const handler = withDurableFunctions<unknown, unknown>(
         async (_event: unknown, context: DurableContext) => {
           try {
             const result = await context.waitForCallback<{ data: string }>(

packages/aws-durable-execution-sdk-js/bundle-size-history.json

@@ -1,9 +1,4 @@
 [
-  {
-    "timestamp": "2025-06-27T16:46:43.149Z",
-    "size": 888765,
-    "gitCommit": "6c98b2ec2c523a92309a7b8ee00e9c61f83392cf"
-  },
   {
     "timestamp": "2025-06-27T16:47:20.156Z",
     "size": 888765,
@@ -248,5 +243,10 @@
     "timestamp": "2025-09-29T03:15:18.425Z",
     "size": 361568,
     "gitCommit": "71b458e8159dfc4242c4e8c65820a6c21554e16c"
+  },
+  {
+    "timestamp": "2025-09-29T21:53:05.018Z",
+    "size": 361581,
+    "gitCommit": "1eba8c6d9f097275746307697346a5f2caf27c23"
   }
 ]

packages/aws-durable-execution-sdk-js/src/errors/serdes-errors/serdes-errors.test.ts

@@ -248,7 +248,7 @@ describe("Serdes Errors", () => {
       });
 
       // Call safeSerialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeSerialize(
+      safeSerialize(
         mockSerdes,
         value,
         TEST_CONSTANTS.STEP_ID_1,
@@ -276,7 +276,7 @@ describe("Serdes Errors", () => {
       });
 
       // Call safeSerialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeSerialize(
+      safeSerialize(
         mockSerdes,
         value,
         TEST_CONSTANTS.STEP_ID_1,
@@ -304,7 +304,7 @@ describe("Serdes Errors", () => {
       });
 
       // Call safeSerialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeSerialize(
+      safeSerialize(
         mockSerdes,
         value,
         TEST_CONSTANTS.STEP_ID_1,
@@ -331,7 +331,7 @@ describe("Serdes Errors", () => {
       mockSerdes.serialize.mockRejectedValue(originalError);
 
       // Call safeSerialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeSerialize(
+      safeSerialize(
         mockSerdes,
         value,
         TEST_CONSTANTS.STEP_ID_1,
@@ -357,7 +357,7 @@ describe("Serdes Errors", () => {
       mockSerdes.serialize.mockRejectedValue("Async string error");
 
       // Call safeSerialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeSerialize(
+      safeSerialize(
         mockSerdes,
         value,
         TEST_CONSTANTS.STEP_ID_1,
@@ -383,7 +383,7 @@ describe("Serdes Errors", () => {
       mockSerdes.serialize.mockRejectedValue("Async string error");
 
       // Call safeSerialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeSerialize(
+      safeSerialize(
         mockSerdes,
         value,
         TEST_CONSTANTS.STEP_ID_1,
@@ -469,7 +469,7 @@ describe("Serdes Errors", () => {
       });
 
       // Call safeDeserialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeDeserialize(
+      safeDeserialize(
         mockSerdes,
         data,
         TEST_CONSTANTS.STEP_ID_1,
@@ -497,7 +497,7 @@ describe("Serdes Errors", () => {
       });
 
       // Call safeDeserialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeDeserialize(
+      safeDeserialize(
         mockSerdes,
         data,
         TEST_CONSTANTS.STEP_ID_1,
@@ -525,7 +525,7 @@ describe("Serdes Errors", () => {
       });
 
       // Call safeDeserialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeDeserialize(
+      safeDeserialize(
         mockSerdes,
         data,
         TEST_CONSTANTS.STEP_ID_1,
@@ -552,7 +552,7 @@ describe("Serdes Errors", () => {
       mockSerdes.deserialize.mockRejectedValue(originalError);
 
       // Call safeDeserialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeDeserialize(
+      safeDeserialize(
         mockSerdes,
         data,
         TEST_CONSTANTS.STEP_ID_1,
@@ -578,7 +578,7 @@ describe("Serdes Errors", () => {
       mockSerdes.deserialize.mockRejectedValue("Async string error");
 
       // Call safeDeserialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeDeserialize(
+      safeDeserialize(
         mockSerdes,
         data,
         TEST_CONSTANTS.STEP_ID_1,
@@ -604,7 +604,7 @@ describe("Serdes Errors", () => {
       mockSerdes.deserialize.mockRejectedValue("Async string error");
 
       // Call safeDeserialize but don't await it (it will never resolve due to termination)
-      const resultPromise = safeDeserialize(
+      safeDeserialize(
         mockSerdes,
         data,
         TEST_CONSTANTS.STEP_ID_1,