From 1fb17648744e9f5b375b869bd710cb378b7a4638 Mon Sep 17 00:00:00 2001 From: Barret Pickett Date: Mon, 14 Sep 2026 19:09:19 +0000 Subject: [PATCH] fix: add training_plan_arn to compute MagicMock in serverful tests The training_plan_arn passthrough fix causes Pydantic validation errors in tests that use MagicMock for the compute object without explicitly setting training_plan_arn. MagicMock returns a MagicMock object instead of None/string, which Pydantic rejects. Add training_plan_arn=None to the compute MagicMock in test_base_trainer_serverful.py and test_serverful_recipe_validation.py. --- sagemaker-train/tests/unit/train/test_base_trainer_serverful.py | 1 + .../tests/unit/train/test_serverful_recipe_validation.py | 1 + 2 files changed, 2 insertions(+) diff --git a/sagemaker-train/tests/unit/train/test_base_trainer_serverful.py b/sagemaker-train/tests/unit/train/test_base_trainer_serverful.py index 18cc798475..590a5cc987 100644 --- a/sagemaker-train/tests/unit/train/test_base_trainer_serverful.py +++ b/sagemaker-train/tests/unit/train/test_base_trainer_serverful.py @@ -31,6 +31,7 @@ def __init__(self, **kwargs): instance_count=1, volume_size_in_gb=100, keep_alive_period_in_seconds=None, + training_plan_arn=None, ) self.networking = None self.stopping_condition = None diff --git a/sagemaker-train/tests/unit/train/test_serverful_recipe_validation.py b/sagemaker-train/tests/unit/train/test_serverful_recipe_validation.py index 9e79839959..2c568e63b3 100644 --- a/sagemaker-train/tests/unit/train/test_serverful_recipe_validation.py +++ b/sagemaker-train/tests/unit/train/test_serverful_recipe_validation.py @@ -41,6 +41,7 @@ def __init__(self, **kwargs): instance_count=4, volume_size_in_gb=100, keep_alive_period_in_seconds=None, + training_plan_arn=None, ) self.networking = None self.stopping_condition = None