Pass payload by value to enable moving arguments (#173)

* Pass payload by value to enable moving arguments

* Update the tests to use std::move

* empty commit

Co-authored-by: Bryan Moffatt <bmoffatt@users.noreply.github.com>
Co-authored-by: Bryan Moffatt <bryan@bryanmoffatt.com>

Author: marcomagdy

examples/dynamodb/main.cpp

@@ -173,9 +173,9 @@ aws::lambda_runtime::invocation_response my_handler(
     if (cr.error_msg) {
         JsonValue response;
         response.WithString("body", cr.error_msg).WithInteger("statusCode", 400);
-        auto const apig_response = response.View().WriteCompact();
+        auto apig_response = response.View().WriteCompact();
         AWS_LOGSTREAM_ERROR(TAG, "Validation failed. " << apig_response);
-        return aws::lambda_runtime::invocation_response::success(apig_response, "application/json");
+        return aws::lambda_runtime::invocation_response::success(std::move(apig_response), "application/json");
     }
 
     auto result = query(cr, client);
@@ -190,10 +190,10 @@ aws::lambda_runtime::invocation_response my_handler(
         response.WithString("body", "No data found for this product.").WithInteger("statusCode", 400);
     }
 
-    auto const apig_response = response.View().WriteCompact();
+    auto apig_response = response.View().WriteCompact();
     AWS_LOGSTREAM_DEBUG(TAG, "api gateway response: " << apig_response);
 
-    return aws::lambda_runtime::invocation_response::success(apig_response, "application/json");
+    return aws::lambda_runtime::invocation_response::success(std::move(apig_response), "application/json");
 }
 
 std::function<std::shared_ptr<Aws::Utils::Logging::LogSystemInterface>()> GetConsoleLoggerFactory()

examples/s3/main.cpp

@@ -50,7 +50,7 @@ static invocation_response my_handler(invocation_request const& req, Aws::S3::S3
         return invocation_response::failure(err, "DownloadFailure");
     }
 
-    return invocation_response::success(base64_encoded_file, "application/base64");
+    return invocation_response::success(std::move(base64_encoded_file), "application/base64");
 }
 
 std::function<std::shared_ptr<Aws::Utils::Logging::LogSystemInterface>()> GetConsoleLoggerFactory()

include/aws/lambda-runtime/runtime.h

@@ -105,7 +105,7 @@ class invocation_response {
     /**
      * Create a successful invocation response with the given payload and content-type.
      */
-    static invocation_response success(std::string const& payload, std::string const& content_type);
+    static invocation_response success(std::string payload, std::string content_type);
 
     /**
      * Create a failure response with the given error message and error type.

src/runtime.cpp

@@ -506,12 +506,12 @@ static std::string json_escape(std::string const& in)
 }
 
 AWS_LAMBDA_RUNTIME_API
-invocation_response invocation_response::success(std::string const& payload, std::string const& content_type)
+invocation_response invocation_response::success(std::string payload, std::string content_type)
 {
     invocation_response r;
     r.m_success = true;
-    r.m_content_type = content_type;
-    r.m_payload = payload;
+    r.m_content_type = std::move(content_type);
+    r.m_payload = std::move(payload);
     return r;
 }
 

tests/resources/lambda_function.cpp

@@ -23,8 +23,8 @@ invocation_response echo_failure(invocation_request const& /*request*/)
 
 invocation_response binary_response(invocation_request const& /*request*/)
 {
-    const std::string png((char*)awslogo_png, AWSLOGO_PNG_LEN);
-    return invocation_response::success(png, "image/png");
+    std::string png((char*)awslogo_png, AWSLOGO_PNG_LEN);
+    return invocation_response::success(std::move(png), "image/png");
 }
 
 invocation_response crash_backtrace(invocation_request const& /*request*/)