From 07baaa5d85f5ff3afd1928394049b0c8eb274927 Mon Sep 17 00:00:00 2001 From: azank Date: Tue, 13 Oct 2026 18:02:15 +0500 Subject: [PATCH] city: reconcile GitHub's commit count for repo and org cities, in numbers A repo city's panel said "Buildings show every non-merge commit on the default branch since 2025-10-13", and for golang/go drew 3,491 where GitHub counts 3,748 since that day. A reader takes "since" as "landed since", which would be 3,716; the city goes by the day a commit was written. An audit of golang/go against GitHub's own history accounts for every commit: 3,748 = 3,491 non-merge commits written since the window start (the buildings, exactly) + 32 merges + 225 commits written earlier and landed since (Gerrit changes sit in review, one since 2016). The finish step already has GitHub's count for each repo (discovery's history(since), by landing day), and each record holds every commit with its merge flag and author minute. For repo and org cities the payload now carries totals.landed: GitHub's count for the drawn repos and the merges written in the window. The panel reads: GitHub counts 3,748 commits on the default branch since 2025-10-13, by the day each landed. Buildings show the 3,491 written since then. Not drawn: 32 merges and 225 commits written before 2025-10-13. The split is given only where it adds up exactly: every drawn repo has GitHub's count, no record is approximate or cut at its 20,000-commit cap, and the count is not below the buildings and merges. Otherwise, and for payloads from before this or from the Python CLI, the panel says what it draws without the ambiguity: every non-merge commit written since the window start. --- commit_city/viewer.html | 30 +++++++++---------- viewer/src/main.js | 13 +++++++- web/lib/city.ts | 1 + web/lib/engine/bundle.ts | 21 +++++++++++-- web/lib/engine/replay.ts | 2 +- web/lib/viewer-shell.ts | 2 +- .../{app.a63cdb5695.js => app.021aac7758.js} | 30 +++++++++---------- web/test/bundle.test.ts | 29 ++++++++++++++++++ 8 files changed, 92 insertions(+), 36 deletions(-) rename web/public/v/{app.a63cdb5695.js => app.021aac7758.js} (95%) diff --git a/commit_city/viewer.html b/commit_city/viewer.html index ad631cb..cb11803 100644 --- a/commit_city/viewer.html +++ b/commit_city/viewer.html @@ -316,11 +316,11 @@